Re: [linux-next:master 7775/11093] drivers/firmware/arm_scmi/quirks.c:110:28: error: implicit declaration of function '__VA_OPT__'; did you mean '__CHAR_BIT__'?

[Cristian Marussi <cristian.marussi@arm.com>]

On Wed, May 14, 2025 at 10:33:06PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   bdd609656ff5573db9ba1d26496a528bdd297cf2
> commit: 7b487beab7cd853ab7de58746284898fb9316334 [7775/11093] firmware: arm_scmi: quirk: Fix CLOCK_DESCRIBE_RATES triplet
> config: arm64-randconfig-r072-20250513 (https://download.01.org/0day-ci/archive/20250514/202505142257.ejBGy5gg-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505142257.ejBGy5gg-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505142257.ejBGy5gg-lkp@intel.com/
> 
> Note: the linux-next/master HEAD bdd609656ff5573db9ba1d26496a528bdd297cf2 builds fine.
>       It may have been fixed somewhere.
> 

Hi,

> All errors (new ones prefixed by >>):
> 
> >> drivers/firmware/arm_scmi/quirks.c:110:28: error: implicit declaration of function '__VA_OPT__'; did you mean '__CHAR_BIT__'? [-Werror=implicit-function-declaration]
>       .compats = { __VA_ARGS__ __VA_OPT__(,) NULL },  \
>                                ^
>    drivers/firmware/arm_scmi/quirks.c:158:2: note: in expansion of macro '__DEFINE_SCMI_QUIRK_ENTRY'
>      __DEFINE_SCMI_QUIRK_ENTRY(_qn, _ven, _sub, _impl, ##__VA_ARGS__)
>      ^~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/firmware/arm_scmi/quirks.c:172:1: note: in expansion of macro 'DEFINE_SCMI_QUIRK'
>     DEFINE_SCMI_QUIRK(clock_rates_triplet_out_of_spec, NULL, NULL, NULL);
>     ^~~~~~~~~~~~~~~~~
> >> drivers/firmware/arm_scmi/quirks.c:110:39: error: expected expression before ',' token
>       .compats = { __VA_ARGS__ __VA_OPT__(,) NULL },  \
>                                           ^
>    drivers/firmware/arm_scmi/quirks.c:158:2: note: in expansion of macro '__DEFINE_SCMI_QUIRK_ENTRY'
>      __DEFINE_SCMI_QUIRK_ENTRY(_qn, _ven, _sub, _impl, ##__VA_ARGS__)
>      ^~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/firmware/arm_scmi/quirks.c:172:1: note: in expansion of macro 'DEFINE_SCMI_QUIRK'
>     DEFINE_SCMI_QUIRK(clock_rates_triplet_out_of_spec, NULL, NULL, NULL);
>     ^~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 

__VA_OPT__ needs a newer GCC to be used, BUT minimum GCC requirements were raised
this cycle, so it should be fine once the toolchains are updated everywhere....
....see this thread:

https://lore.kernel.org/linux-arm-kernel/94e94c5f-210b-43b8-99bc-e7ad7da2588d@app.fastmail.com/

Thanks,
Cristian

> 
> vim +110 drivers/firmware/arm_scmi/quirks.c
> 
> 487c407d57d6d3 Cristian Marussi 2025-04-29  102  
> 487c407d57d6d3 Cristian Marussi 2025-04-29  103  #define __DEFINE_SCMI_QUIRK_ENTRY(_qn, _ven, _sub, _impl, ...)	\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  104  	static struct scmi_quirk scmi_quirk_entry_ ## _qn = {		\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  105  		.name = __stringify(quirk_ ## _qn),			\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  106  		.vendor = _ven,						\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  107  		.sub_vendor_id = _sub,					\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  108  		.impl_ver_range = _impl,				\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  109  		.key = &(scmi_quirk_ ## _qn),				\
> 487c407d57d6d3 Cristian Marussi 2025-04-29 @110  		.compats = { __VA_ARGS__ __VA_OPT__(,) NULL },		\
> 487c407d57d6d3 Cristian Marussi 2025-04-29  111  	}
> 487c407d57d6d3 Cristian Marussi 2025-04-29  112  
> 
> :::::: The code at line 110 was first introduced by commit
> :::::: 487c407d57d6d32ff4370f4e738227811732d4bd firmware: arm_scmi: Add common framework to handle firmware quirks
> 
> :::::: TO: Cristian Marussi <cristian.marussi@arm.com>
> :::::: CC: Sudeep Holla <sudeep.holla@arm.com>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki