From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A36A26AC3 for ; Wed, 14 May 2025 23:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747265052; cv=none; b=uf5Spsp++FUFU/KqKL9xNtXv4a/UcgBtWpbCxkwOl+NGeZlJPtF8MDAcSxuE41q+FluRmCUy0zTKZr/5hhyVClMVnZce1TWz7H6o9z7KzPuwDmvvccx0AWcyQVUc+57bTvu6058dEvCUkFh9esXwsg/ke3br7uCVaRwRbaahG/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747265052; c=relaxed/simple; bh=Nmp9kwZTSuh5uyM03fYV50SB5KKk+Itz81IL9dk1N44=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=J9LzX9hxrt6MiOhZCf5RtRsEiLm9er/SqX1IVLJDY21IiV9kEea2bITtRpQ7JlRHYiZQxcZiq4mokVmdcfIOeT9NWBzLshUerO26Qm+Ed9wTe3BjuIVbjp5RCz+kD6HkVJ9jnqYumiRHo+Zg4Ajs0r5fc2ltkNzSnnpTHeNugz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CNNCtkJm; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CNNCtkJm" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30a29af28d1so343418a91.0 for ; Wed, 14 May 2025 16:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747265050; x=1747869850; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zJfnwMvDMyYbKEUav/eMFbw+CnQxNcQAe0tdAXtp/6s=; b=CNNCtkJmdUPTKbYOgJTvgXIRMaDPveFFXo21OrZuLlATM30XT6d3o6AgTpA14LZaoF RK7+sl1xc5biU9gfbAUTACQ3Wbhlh4pOR5uSmC7dZGKH+XVAOaT0r3osiJrLEfYkyoAg 9fSyJVOyUfdWLxBmF7xU7NpuTmsS9JBoyuFDNFCBL1aziqyenYbsCWiBxUk4/H2YBMGM f4PxG0X3JVqqZH0LyYAaSVX7EK7VcEk14ueeYg6vRZoGf+wsmmnysPMlSdbOO+Cdi8lQ iRdqnJPB+WLfakEdczmdgUlSlFeQ9+XBPaBzXYw1T2VdrpmJU89+SVa54rZWDFmN+GEU hW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747265050; x=1747869850; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zJfnwMvDMyYbKEUav/eMFbw+CnQxNcQAe0tdAXtp/6s=; b=FiySPT3O7RSL3AU645fcbXTz62RHyaJjCWDXv9rmy/WJIESvgIzOTTJD/hYW9M4eiW xb0WNld5B3Pfo0GtnyJnvGIeeJS67LkcOhptI92QH4I1OOseR2F8gqcrw47By1cz5RAv lzRFGr/4vjBW1dwy4sk7ufD9r2XZda5iuxp2NPTYK8nwWkGnIBMhJqGrx0m6YI8r56Y8 REzHDZhKUfdHDQEyj+hsQubBWixr63yFx4OGAiFXuoVF1KuImruiBf2P1ba3Ufvihher AwhPSP4nX8cLptFmqHLtihSzOXJpSGKZq+8gqEApPxfOwMtMlQTgOgUKjaUkSDRKlybs RICA== X-Forwarded-Encrypted: i=1; AJvYcCV+P5gBDFhhXDzg7RfpsUfdNVEXF1/bZKemefxJmtCrf17xR/3gI6kOxv1j/3s1tnA1G18=@vger.kernel.org X-Gm-Message-State: AOJu0YyJgV0qQ0ZMYdaAaZyP0zIlbfpxxAHMWK22pboZpmxKdi3sKHlq cJlqmn669pycgtTJHgWoqEv7/HDwm6oYyTAjvoxOND2fjLeCAI3PtWmuOr89dYQeSgDVQJ1/bDa AAg== X-Google-Smtp-Source: AGHT+IFwSrO5NhBZmvoRVsyrPRAz/VlvVDh4aecdu/eb1bYHiTkHDlLm1inaF+lX2qdyGijklr9h4dTHe9Y= X-Received: from pjzz6.prod.google.com ([2002:a17:90b:58e6:b0:2ea:448a:8cd1]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d4b:b0:2fe:e0a9:49d4 with SMTP id 98e67ed59e1d1-30e2e5818bcmr8614984a91.2.1747265050136; Wed, 14 May 2025 16:24:10 -0700 (PDT) Date: Wed, 14 May 2025 16:24:08 -0700 In-Reply-To: <20250324173121.1275209-8-mizhang@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250324173121.1275209-1-mizhang@google.com> <20250324173121.1275209-8-mizhang@google.com> Message-ID: Subject: Re: [PATCH v4 07/38] perf: core/x86: Register a new vector for KVM GUEST PMI From: Sean Christopherson To: Mingwei Zhang Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Liang@google.com, Kan , "H. Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Yongwei Ma , Xiong Zhang , Dapeng Mi , Jim Mattson , Sandipan Das , Zide Chen , Eranian Stephane , Shukla Manali , Nikunj Dadhania Content-Type: text/plain; charset="us-ascii" On Mon, Mar 24, 2025, Mingwei Zhang wrote: > diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h > index ad5c68f0509d..b0cb3220e1bb 100644 > --- a/arch/x86/include/asm/idtentry.h > +++ b/arch/x86/include/asm/idtentry.h > @@ -745,6 +745,7 @@ DECLARE_IDTENTRY_SYSVEC(IRQ_WORK_VECTOR, sysvec_irq_work); > DECLARE_IDTENTRY_SYSVEC(POSTED_INTR_VECTOR, sysvec_kvm_posted_intr_ipi); > DECLARE_IDTENTRY_SYSVEC(POSTED_INTR_WAKEUP_VECTOR, sysvec_kvm_posted_intr_wakeup_ipi); > DECLARE_IDTENTRY_SYSVEC(POSTED_INTR_NESTED_VECTOR, sysvec_kvm_posted_intr_nested_ipi); > +DECLARE_IDTENTRY_SYSVEC(KVM_GUEST_PMI_VECTOR, sysvec_kvm_guest_pmi_handler); I would prefer to keep KVM out of the name, and as mentioned in the previous patch, route this through perf. > #else > # define fred_sysvec_kvm_posted_intr_ipi NULL > # define fred_sysvec_kvm_posted_intr_wakeup_ipi NULL Y'all forgot to wire up the FRED handling. I.e. the mediated PMI IRQs would get treated as spurious when running with FRED. > diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h > index 47051871b436..250cdab11306 100644 > --- a/arch/x86/include/asm/irq_vectors.h > +++ b/arch/x86/include/asm/irq_vectors.h > @@ -77,7 +77,10 @@ > */ > #define IRQ_WORK_VECTOR 0xf6 > > -/* 0xf5 - unused, was UV_BAU_MESSAGE */ > +#if IS_ENABLED(CONFIG_KVM) > +#define KVM_GUEST_PMI_VECTOR 0xf5 > +#endif Conditionally defining the vector sounds good on paper, but its problematic, e.g. for connecting the handler to FRED's array, and doesn't really add much value. > #define DEFERRED_ERROR_VECTOR 0xf4 > > /* Vector on which hypervisor callbacks will be delivered */ > diff --git a/arch/x86/kernel/idt.c b/arch/x86/kernel/idt.c > index f445bec516a0..0bec4c7e2308 100644 > --- a/arch/x86/kernel/idt.c > +++ b/arch/x86/kernel/idt.c > @@ -157,6 +157,7 @@ static const __initconst struct idt_data apic_idts[] = { > INTG(POSTED_INTR_VECTOR, asm_sysvec_kvm_posted_intr_ipi), > INTG(POSTED_INTR_WAKEUP_VECTOR, asm_sysvec_kvm_posted_intr_wakeup_ipi), > INTG(POSTED_INTR_NESTED_VECTOR, asm_sysvec_kvm_posted_intr_nested_ipi),