All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: valgrind-developers@lists.sourceforge.net,
	Mark Wielaard <mark@klomp.org>,
	Martin Cermak <mcermak@redhat.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] lib: tst_test: Add reproducible output.
Date: Thu, 15 May 2025 12:34:18 +0200	[thread overview]
Message-ID: <aCXDKh_biyimb32N@yuki.lan> (raw)
In-Reply-To: <20250512180605.GA337908@pevik>

Hi!
> LTP_COLORIZE_OUTPUT allows more complicated setup (y/1 always, n/0: never),
> but any value here enables the feature (e.g. LTP_COLORIZE_OUTPUT=0).
> This would be nice to unify, but I'm ok to ignore it as it's before release.

We also have LTP_ENABLE_DEBUG that has the same values so let's keep the
API the same. I've send v3 with this and the docs changes.

> > +
> >  	assert_test_fn();
> 
> >  	TCID = tid = get_tid(argv);
> 
> Adding docs (+ sort variables while at it).

I've only added the docs for LTP_REPRODUCIBLE_OUTPUT in v3, the sorting
should go in a separate patch. We also miss at least TST_ENABLE_DEBUG in
the output of -h switch as well.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-05-15 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09  9:28 [LTP] [PATCH v2] lib: tst_test: Add reproducible output Cyril Hrubis
2025-05-09  9:36 ` Martin Doucha
2025-05-12  9:47 ` Avinesh Kumar
2025-05-12 18:06 ` Petr Vorel
2025-05-15 10:34   ` Cyril Hrubis [this message]
2025-05-16 20:29     ` Martin Cermak via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCXDKh_biyimb32N@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mark@klomp.org \
    --cc=mcermak@redhat.com \
    --cc=pvorel@suse.cz \
    --cc=valgrind-developers@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.