From: Christoph Hellwig <hch@infradead.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Yushan Zhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function
Date: Thu, 15 May 2025 22:06:29 -0700 [thread overview]
Message-ID: <aCbH1eA8Iicg_Fq_@infradead.org> (raw)
In-Reply-To: <CAL+tcoBtLu6_E1qKL9VHOiCe_RVpEGzMiMqA3GpPi1Z88aMiWw@mail.gmail.com>
On Fri, May 16, 2025 at 01:02:59PM +0800, Jason Xing wrote:
> Do you mean make it inline in include/linux/relay.h like how
> relay_write() works?
>
> Will do that.
Just drop the extern, which is not needed:
size_t relay_dump(struct rchan *chan, int flags);
> >
> > This export seems unused even with the entire series applied.
>
> My initial thought was to provide a symbol for some kernel modules to use.
The only user is blktrace, which can't be modular. Or you plan to
submit a modular user soon, like in the next merge window/ If so
note that and add a pointer to it in the cover letter.
next prev parent reply other threads:[~2025-05-16 5:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 6:16 [PATCH v2 0/4] relayfs: misc changes Jason Xing
2025-05-15 6:16 ` [PATCH v2 1/4] relayfs: support a counter tracking if per-cpu buffers is full Jason Xing
2025-05-15 18:17 ` Jens Axboe
2025-05-15 6:16 ` [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 23:24 ` Jason Xing
2025-05-16 2:08 ` Masami Hiramatsu
2025-05-16 2:32 ` Jason Xing
2025-05-16 4:37 ` Christoph Hellwig
2025-05-16 5:02 ` Jason Xing
2025-05-16 5:06 ` Christoph Hellwig [this message]
2025-05-16 5:44 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 3/4] blktrace: use rbuf->stats.full as a drop indicator in relayfs Jason Xing
2025-05-15 18:19 ` Jens Axboe
2025-05-15 18:21 ` Jens Axboe
2025-05-15 23:26 ` Jason Xing
2025-05-15 6:16 ` [PATCH v2 4/4] relayfs: support a counter tracking if data is too big to write Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCbH1eA8Iicg_Fq_@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=katrinzhou@tencent.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.