From: Andy Shevchenko <andy@kernel.org>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
nuno.sa@analog.com, Michael.Hennerich@analog.com,
marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
jonath4nns@gmail.com, dlechner@baylibre.com
Subject: Re: [PATCH v8 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute
Date: Fri, 16 May 2025 12:38:28 +0300 [thread overview]
Message-ID: <aCcHlAE8LvO_fLxQ@smile.fi.intel.com> (raw)
In-Reply-To: <42dc4d7722996a8d64a1bbafd8848609c9e435d8.1747175187.git.Jonathan.Santos@analog.com>
On Thu, May 15, 2025 at 06:14:33PM -0300, Jonathan Santos wrote:
> Ad7768-1 has a different -3db frequency multiplier depending on
> the filter type configured. The cutoff frequency also varies according
> to the current ODR.
>
> Add a readonly low pass -3dB frequency cutoff attribute to clarify to
> the user which bandwidth is being allowed depending on the filter
> configurations.
...
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
> - BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY),
You can make the diff looking better and easier to review if squeeze the new
bit in between of the existing one, this will remove +- LoC here.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-05-16 9:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 21:11 [PATCH v8 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 02/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-05-15 21:12 ` [PATCH v8 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 04/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-05-15 21:13 ` [PATCH v8 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-05-16 9:24 ` Andy Shevchenko
2025-05-15 21:13 ` [PATCH v8 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-05-15 22:46 ` David Lechner
2025-05-16 9:29 ` Andy Shevchenko
2025-05-18 16:58 ` Jonathan Cameron
2025-05-24 0:00 ` Jonathan Santos
2025-05-25 9:41 ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-05-15 21:14 ` [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-05-16 9:34 ` Andy Shevchenko
2025-05-18 17:03 ` Jonathan Cameron
2025-05-19 17:13 ` Jonathan Santos
2025-05-19 20:15 ` David Lechner
2025-05-19 22:31 ` Jonathan Santos
2025-05-25 9:44 ` Jonathan Cameron
2025-05-15 21:14 ` [PATCH v8 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-05-16 9:38 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCcHlAE8LvO_fLxQ@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.