All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
	Community Manager <community.manager@xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Michal Orzel <michal.orzel@amd.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/6] x86/gnttab: do not implement GNTTABOP_cache_flush
Date: Fri, 16 May 2025 12:31:58 +0200	[thread overview]
Message-ID: <aCcUHtWNBdbK7Iy0@macbook.lan> (raw)
In-Reply-To: <b7d2f338-6918-4052-99e1-733dbb0aac7d@suse.com>

On Fri, May 16, 2025 at 11:48:48AM +0200, Jan Beulich wrote:
> On 16.05.2025 11:45, Roger Pau Monne wrote:
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -35,6 +35,11 @@ config GRANT_TABLE
> >  
> >  	  If unsure, say Y.
> >  
> > +config HAS_GRANT_CACHE_FLUSH
> > +	bool
> > +	depends on GRANT_TABLE
> > +	default ARM
> 
> To keep arch stuff out of common file as much as possible, I think this instead
> wants to be a "select ..." from ARM. Then:
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

My first attempt was to do it as you suggest, but then if the users
disables GRANT_TABLE you get the following warning:

WARNING: unmet direct dependencies detected for HAS_GRANT_CACHE_FLUSH
  Depends on [n]: GRANT_TABLE [=n]
  Selected by [y]:
  - ARM [=y]
configuration written to .config

And you end up with the following on .config:

# CONFIG_GRANT_TABLE is not set
CONFIG_HAS_GRANT_CACHE_FLUSH=y

That's why I've done it the way presented in this patch.

Thanks, Roger.


  reply	other threads:[~2025-05-16 10:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16  9:45 [PATCH v2 0/6] xen: cache control improvements Roger Pau Monne
2025-05-16  9:45 ` [PATCH v2 1/6] x86/pv: fix emulation of wb{,no}invd to flush all pCPU caches Roger Pau Monne
2025-05-18 11:23   ` Jan Beulich
2025-05-16  9:45 ` [PATCH v2 2/6] x86/gnttab: do not implement GNTTABOP_cache_flush Roger Pau Monne
2025-05-16  9:48   ` Jan Beulich
2025-05-16 10:31     ` Roger Pau Monné [this message]
2025-05-16 10:38       ` Jan Beulich
2025-05-16 11:04         ` Roger Pau Monné
2025-05-19  7:45   ` Oleksii Kurochko
2025-05-16  9:45 ` [PATCH v2 3/6] xen/x86: rename cache_flush_permitted() to has_arch_io_resources() Roger Pau Monne
2025-05-18 11:29   ` Jan Beulich
2025-05-16  9:45 ` [PATCH v2 4/6] xen/x86: account for assigned PCI devices in cache_flush_permitted() Roger Pau Monne
2025-05-16  9:45 ` [PATCH v2 5/6] x86/hvm: limit memory type cache flush to running domains Roger Pau Monne
2025-05-18 11:38   ` Jan Beulich
2025-05-19 10:58     ` Roger Pau Monné
2025-05-16  9:45 ` [PATCH v2 6/6] x86/hvm: reduce the need to flush caches in memory_type_changed() Roger Pau Monne
2025-05-18 11:44   ` Jan Beulich
2025-05-19 11:08     ` Roger Pau Monné
2025-05-19 13:22       ` Jan Beulich
2025-05-19 14:33         ` Roger Pau Monné
2025-05-19 18:25           ` Jan Beulich
2025-05-20 14:23           ` Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCcUHtWNBdbK7Iy0@macbook.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=community.manager@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.