All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <superm1@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:HIBERNATION (aka Software Suspend,
	aka swsusp)" <linux-pm@vger.kernel.org>,
	 "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Kai-Heng Feng <kaihengf@nvidia.com>,
	Mark Pearson <mpearson-lenovo@squebb.ca>,
	Denis Benato <benato.denis96@gmail.com>,
	Merthan Karaka?? <m3rthn.k@gmail.com>
Subject: Re: [PATCH v2 2/3] PCI: Put PCIe ports with downstream devices into D3 at hibernate
Date: Sun, 18 May 2025 08:20:07 +0200	[thread overview]
Message-ID: <aCl8F0MA7JXSZYxf@wunner.de> (raw)
In-Reply-To: <20250514193406.3998101-3-superm1@kernel.org>

On Wed, May 14, 2025 at 02:34:05PM -0500, Mario Limonciello wrote:
> Adjust the pci_pm_poweroff_noirq() to follow the same flow as
> pci_pm_suspend_noirq() in that PCIe ports that are power manageable should

Nit: s/should//

> without downstream devices in D0 should be put into their appropriate
> sleep state.

This leads to a lot of code duplication between pci_pm_suspend_noirq()
and pci_pm_poweroff_noirq().  Can the common portion of the code be moved
to a helper invoked by both functions so that it's easier to follow the
logic and understand common and differing parts of the suspend flow?

Thanks,

Lukas

  reply	other threads:[~2025-05-18  6:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 19:34 [PATCH v2 0/3] Improvements to S5 power consumption Mario Limonciello
2025-05-14 19:34 ` [PATCH v2 1/3] PM: Use hibernate flows for system power off Mario Limonciello
2025-05-16 14:58   ` Rafael J. Wysocki
2025-05-16 19:33     ` Mario Limonciello
2025-05-16 19:53       ` Rafael J. Wysocki
2025-05-14 19:34 ` [PATCH v2 2/3] PCI: Put PCIe ports with downstream devices into D3 at hibernate Mario Limonciello
2025-05-18  6:20   ` Lukas Wunner [this message]
2025-05-14 19:34 ` [PATCH v2 3/3] drm/amd: Avoid evicting resources at S5 Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCl8F0MA7JXSZYxf@wunner.de \
    --to=lukas@wunner.de \
    --cc=acelan.kao@canonical.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=benato.denis96@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=kaihengf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m3rthn.k@gmail.com \
    --cc=mario.limonciello@amd.com \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=rafael@kernel.org \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.