From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
qat-linux@intel.com, terrelln@fb.com, dsterba@suse.com
Subject: Re: [PATCH] crypto: zstd - convert to acomp
Date: Sun, 18 May 2025 23:01:54 +0200 [thread overview]
Message-ID: <aCpKwjzLoqUi5ZwK@Red> (raw)
In-Reply-To: <20250516154331.1651694-1-suman.kumar.chakraborty@intel.com>
Le Fri, May 16, 2025 at 04:43:31PM +0100, Suman Kumar Chakraborty a écrit :
> Convert the implementation to a native acomp interface using zstd
> streaming APIs, eliminating the need for buffer linearization.
>
> This includes:
> - Removal of the scomp interface in favor of acomp
> - Refactoring of stream allocation, initialization, and handling for
> both compression and decompression using Zstandard streaming APIs
> - Replacement of crypto_register_scomp() with crypto_register_acomp()
> for module registration
>
> Signed-off-by: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
This patch lead to a selftest failure on qemu ARM:
[ 8.966883] alg: self-tests for zstd using zstd-generic failed (rc=-22)
[ 8.967242] ------------[ cut here ]------------
[ 8.968659] WARNING: CPU: 0 PID: 64 at crypto/testmgr.c:5808 alg_test+0x42c/0x654
[ 8.971391] alg: self-tests for zstd using zstd-generic failed (rc=-22)
[ 8.971716] Modules linked in:
[ 8.973531] CPU: 0 UID: 0 PID: 64 Comm: cryptomgr_test Not tainted 6.15.0-rc5-g0f25e6007813-dirty #113 NONE
[ 8.974311] Hardware name: Generic DT based system
[ 8.975088] Call trace:
[ 8.976322] unwind_backtrace from show_stack+0x10/0x14
[ 8.977257] show_stack from dump_stack_lvl+0x54/0x68
[ 8.977910] dump_stack_lvl from __warn+0x80/0x124
[ 8.978418] __warn from warn_slowpath_fmt+0x124/0x18c
[ 8.979081] warn_slowpath_fmt from alg_test+0x42c/0x654
[ 8.979645] alg_test from cryptomgr_test+0x18/0x38
[ 8.980054] cryptomgr_test from kthread+0x108/0x234
[ 8.980603] kthread from ret_from_fork+0x14/0x28
[ 8.981254] Exception stack(0xdfb7dfb0 to 0xdfb7dff8)
[ 8.982194] dfa0: 00000000 00000000 00000000 00000000
[ 8.982734] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 8.983394] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 8.984699] ---[ end trace 0000000000000000 ]---
Regards
next prev parent reply other threads:[~2025-05-18 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 15:43 [PATCH] crypto: zstd - convert to acomp Suman Kumar Chakraborty
2025-05-16 17:06 ` Eric Biggers
2025-05-19 14:50 ` Nick Terrell
2025-05-18 21:01 ` Corentin Labbe [this message]
2025-05-20 7:57 ` Suman Kumar Chakraborty
2025-05-20 12:13 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCpKwjzLoqUi5ZwK@Red \
--to=clabbe.montjoie@gmail.com \
--cc=dsterba@suse.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=suman.kumar.chakraborty@intel.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.