From: Patrick Steinhardt <ps@pks.im>
To: lidongyan <502024330056@smail.nju.edu.cn>
Cc: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] pack-bitmap: add loading corrupt bitmap_index test
Date: Mon, 19 May 2025 09:27:21 +0200 [thread overview]
Message-ID: <aCrdWbcOtbYsw8t6@pks.im> (raw)
In-Reply-To: <80BCF957-002B-4532-8E3D-8CAB45AC0349@smail.nju.edu.cn>
On Mon, May 19, 2025 at 02:44:22PM +0800, lidongyan wrote:
> 2025年5月19日 14:02，Patrick Steinhardt <ps@pks.im> 写道：
> > Okay. We _can_ do that now, but the patch doesn't explain why we
> > _should_.
>
> The main purpose of this patch is to provide a test case to check whether
> a memory leak occurs when loading a corrupt index file as requested here
> https://lore.kernel.org/git/20250514180325.GB2196784@coredump.intra.peff.net.
> A potential memory leak is mentioned in this patch here https://lore.kernel.org/git/pull.1962.git.git.1747052530271.gitgitgadget@gmail.com/.
Wouldn't it make sense to include this in a v2 of that patch series
then? That makes it way easier for the reviewer to draw the connection
and allows you to draft commit messages in a way that they refer to one
another.
Patrick
next prev parent reply other threads:[~2025-05-19 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 14:26 [PATCH] pack-bitmap: add loading corrupt bitmap_index test Lidong Yan via GitGitGadget
2025-05-19 6:02 ` Patrick Steinhardt
2025-05-19 6:44 ` lidongyan
2025-05-19 7:27 ` Patrick Steinhardt [this message]
2025-05-19 7:37 ` lidongyan
2025-05-19 7:39 ` Jeff King
2025-05-19 7:58 ` lidongyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCrdWbcOtbYsw8t6@pks.im \
--to=ps@pks.im \
--cc=502024330056@smail.nju.edu.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.