From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7D013AC1 for ; Mon, 19 May 2025 07:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747641009; cv=none; b=MoVkMq4xfW4KYferBEQDUFisOdF5QU79tDPCIUOuZ1w8JqWXJKUBxw71SE4hhu89Kz7CpZtKiTTdzyR0H7LNC6JUCO2zhnuCnswjYUU/Eb4xCdYYfspxyxNzoYI2Iu8a61yc4SbBw8dzuQqBMUV7vgUjlYhzLngOuHyYYYvgRfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747641009; c=relaxed/simple; bh=7AYBXBv9hJZfDoLFBvBon3/3G/8xWmXD3D7ANQ1f3jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ACLoMVKhzTOeoeQsJS0EknPZln2PHq2Bz4rSq13G624zMOZSPiv+y1neYUKhZh6x69BCc/eqVzC7+gVyDWBXjXClldrcx0Q0ZJxO/rtz7lkBPrGa5QqO7dNJ+WwTE6bUO7OE0QFpWxEOsHCApix9ha0kDxX/Y9Q+z0wVUqXsQ78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=OXhGwQ3g; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="OXhGwQ3g" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8687726048; Mon, 19 May 2025 09:50:04 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ovcAx9lpnpgW; Mon, 19 May 2025 09:50:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1747641003; bh=7AYBXBv9hJZfDoLFBvBon3/3G/8xWmXD3D7ANQ1f3jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OXhGwQ3g2G/nirDRBc2kkgRofonOnnq3yruIY9oMnedr84KF1isk3GDb3lxpIjDZP IZIu28K9c0x6xyZllGhSb4W+YJqDNR1VWGd99D/jXR3nur78tQHQP2o1bXngKLRgif zwGnPACWX29107UwopKMoh09lX1mPKeXN7AtBwyJzqYG/R7+h7lvAWSVX01Sk1FJe+ XIOdrroksMRxxdla4itzkO6RSfgwtEhNhZJziR4GDrt16v44naqm1h8VG1gL+tufD5 /ttR+4tRCr60jvOV7usyJdHt8BQU6tG4ClZj37+5HWRjqJ5bKIUMAK5NzY5uPMrSy7 p5fXrGV0cdbtw== Date: Mon, 19 May 2025 07:49:47 +0000 From: Yao Zi To: Binbin Zhou Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Huacai Chen , WANG Xuerui , Neil Armstrong , Heiko Stuebner , Junhao Xie , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Aradhya Bhatia , Manivannan Sadhasivam , Binbin Zhou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Mingcong Bai , Kexy Biscuit Subject: Re: [PATCH v2 3/4] LoongArch: dts: Add initial SoC devicetree for Loongson 2K0300 Message-ID: References: <20250518080356.43885-1-ziyao@disroot.org> <20250518080356.43885-4-ziyao@disroot.org> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 19, 2025 at 11:10:16AM +0800, Binbin Zhou wrote: > Hi Yao: > > Thanks for your patch. > > On Sun, May 18, 2025 at 4:05 PM Yao Zi wrote: > > > > Add SoC devicetree for 2K0300 SoC, which features one LA264 dual-issue > > core and targets embedded market. Only CPU core, legacy interrupt > > controllers and UARTs are defined for now. > > > > Signed-off-by: Yao Zi > > --- > > arch/loongarch/boot/dts/loongson-2k0300.dtsi | 184 +++++++++++++++++++ > > 1 file changed, 184 insertions(+) > > create mode 100644 arch/loongarch/boot/dts/loongson-2k0300.dtsi > > > > diff --git a/arch/loongarch/boot/dts/loongson-2k0300.dtsi b/arch/loongarch/boot/dts/loongson-2k0300.dtsi > > new file mode 100644 > > index 000000000000..17974f793947 > > --- /dev/null > > +++ b/arch/loongarch/boot/dts/loongson-2k0300.dtsi > > @@ -0,0 +1,184 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2025 Loongson Technology Corporation Limited > > + * Copyright (C) 2025 Yao Zi > > + */ > > + > > +/dts-v1/; > > + > > +#include > > + > > +/ { > > + compatible = "loongson,ls2k0300"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu0: cpu@0 { > > + compatible = "loongson,la264"; > > + reg = <0>; > > + device_type = "cpu"; > > + clocks = <&cpu_clk>; > > + }; > > + > > + }; > > + > > + cpuintc: interrupt-controller { > > + compatible = "loongson,cpu-interrupt-controller"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + }; > > + > > + cpu_clk: clock-1000m { > > + compatible = "fixed-clock"; > > + clock-frequency = <1000000000>; > > + #clock-cells = <0>; > > + }; > > + > > + soc { > I found the following warning while doing dtbs_check, please check again: > > DTC [C] arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dtb > arch/loongarch/boot/dts/loongson-2k0300.dtsi:41.6-183.4: Warning > (unit_address_vs_reg): /soc: node has a reg or ranges property, but no > unit name Oops, seems -Wunit_address_vs_reg is silent without W=1 specified. Commit 8654cb8d0371 (dtc: update warning settings for new bus and node/property name checks, 2017-03-21) shows it's a temporary workaround ("Disable the new dtc warnings by default as there are 1000s"). I'll the node to soc@10000000 in v3. Thanks for catching something I've never noticed before. Yanteng, is it okay for you to keep your reviewed-by tag with the change? > > + compatible = "simple-bus"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges = <0x00 0x10000000 0x00 0x10000000 0x0 0x10000000>, > > + <0x00 0x02000000 0x00 0x02000000 0x0 0x04000000>, > > + <0x00 0x40000000 0x00 0x40000000 0x0 0x40000000>; > > + ... > > 2.49.0 > > > > > > -- > Thanks. > Binbin > Thanks, Yao Zi