All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: 'Michal Swiatkowski' <michal.swiatkowski@linux.intel.com>,
	netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
	edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch,
	mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next] net: libwx: Fix log level
Date: Mon, 19 May 2025 10:14:41 +0200	[thread overview]
Message-ID: <aCrocTkoD9BoOTCm@mev-dev.igk.intel.com> (raw)
In-Reply-To: <000301dbc88c$ca5757e0$5f0607a0$@trustnetic.com>

On Mon, May 19, 2025 at 03:08:15PM +0800, Jiawen Wu wrote:
> On Mon, May 19, 2025 2:56 PM, Michal Swiatkowski wrote:
> > On Mon, May 19, 2025 at 02:33:57PM +0800, Jiawen Wu wrote:
> > > There is a log should be printed as info level, not error level.
> > >
> > > Fixes: 9bfd65980f8d ("net: libwx: Add sriov api for wangxun nics")
> > > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > > ---
> > >  drivers/net/ethernet/wangxun/libwx/wx_sriov.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_sriov.c b/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > index 52e6a6faf715..195f64baedab 100644
> > > --- a/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > +++ b/drivers/net/ethernet/wangxun/libwx/wx_sriov.c
> > > @@ -76,7 +76,7 @@ static int __wx_enable_sriov(struct wx *wx, u8 num_vfs)
> > >  	u32 value = 0;
> > >
> > >  	set_bit(WX_FLAG_SRIOV_ENABLED, wx->flags);
> > > -	wx_err(wx, "SR-IOV enabled with %d VFs\n", num_vfs);
> > > +	dev_info(&wx->pdev->dev, "SR-IOV enabled with %d VFs\n", num_vfs);
> > >
> > >  	/* Enable VMDq flag so device will be set in VM mode */
> > >  	set_bit(WX_FLAG_VMDQ_ENABLED, wx->flags);
> > 
> > It is unclear if you want it to go to net, or net-next (net-next in
> > subject, but fixes tag in commit message). I think it should go to
> > net-next, so fixes tag can be dropped.
> 
> It is because the fixes tag commit is not merged in net yet, so I give it a prefix net-next.
> 
> 

Oh, sorry for not checking that.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

  reply	other threads:[~2025-05-19  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19  6:33 [PATCH net-next] net: libwx: Fix log level Jiawen Wu
2025-05-19  6:56 ` Michal Swiatkowski
2025-05-19  7:08   ` Jiawen Wu
2025-05-19  8:14     ` Michal Swiatkowski [this message]
2025-05-22  3:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCrocTkoD9BoOTCm@mev-dev.igk.intel.com \
    --to=michal.swiatkowski@linux.intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=kuba@kernel.org \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.