Re: [PATCH] roms: re-remove execute bit from hppa-firmware*

["Daniel P. Berrangé" <berrange@redhat.com>]

On Sun, May 18, 2025 at 01:54:20PM -0400, Cole Robinson wrote:
> This was fixed in c9d77526bddba0803a1fa982fb59ec98057150f9 for
> 9.2.0 but regressed in db34be329162cf6b06192703065e6c1010dbe3c5 in
> 10.0.0
> 
> When the bit is present, rpmbuild complains about missing ELF build-id
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  pc-bios/hppa-firmware.img   | Bin
>  pc-bios/hppa-firmware64.img | Bin
>  2 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 pc-bios/hppa-firmware.img
>  mode change 100755 => 100644 pc-bios/hppa-firmware64.img

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Though given the back & forth, I wonder if we wouldn't be better off
changing meson.build rules instead to mode 0644 for all blobs ?

  install_data(blobs,
               install_dir: qemu_datadir,
	       install_mode: 0644)

...assuming none actually need execute bits set.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|