From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Jiqian Chen <Jiqian.Chen@amd.com>, Huang Rui <ray.huang@amd.com>,
Anthony PERARD <anthony.perard@vates.tech>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 07/10] vpci: Refactor vpci_remove_register to remove matched registers
Date: Mon, 19 May 2025 12:24:31 +0200 [thread overview]
Message-ID: <aCsG3-u_3Gh4sm99@Mac.lan> (raw)
In-Reply-To: <7129d506-b03a-4f89-8128-84b8befe8799@suse.com>
On Mon, May 19, 2025 at 08:30:22AM +0200, Jan Beulich wrote:
> On 09.05.2025 11:05, Jiqian Chen wrote:
> > vpci_remove_register() only supports removing a register in a time,
> > but the follow-on changes need to remove all registers within a range.
> > So, refactor it to support removing all matched registers in a calling
> > time.
>
> Generally I'm a little wary of changing behavior for existing callers,
> but I guess Roger already did signal he's okay taking that route?
The only users of that function currently are in tools/tests/vpci/,
so changing is not a problem IMO.
Regards, Roger.
next prev parent reply other threads:[~2025-05-19 10:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 9:05 [PATCH v4 00/10] Support hiding capability when its initialization fails Jiqian Chen
2025-05-09 9:05 ` [PATCH v4 01/10] vpci/header: Move emulating cap list logic into new function Jiqian Chen
2025-05-09 9:05 ` [PATCH v4 02/10] vpci/header: Emulate legacy capability list for dom0 Jiqian Chen
2025-05-15 16:29 ` Roger Pau Monné
2025-05-16 2:33 ` Chen, Jiqian
2025-05-09 9:05 ` [PATCH v4 03/10] vpci/header: Emulate extended " Jiqian Chen
2025-05-18 14:20 ` Jan Beulich
2025-05-19 6:43 ` Chen, Jiqian
2025-05-19 6:56 ` Jan Beulich
2025-05-19 7:13 ` Chen, Jiqian
2025-05-19 13:10 ` Jan Beulich
2025-05-19 13:21 ` Roger Pau Monné
2025-05-21 6:08 ` Chen, Jiqian
2025-05-21 6:25 ` Jan Beulich
2025-05-21 6:44 ` Chen, Jiqian
2025-05-09 9:05 ` [PATCH v4 04/10] vpci: Refactor REGISTER_VPCI_INIT Jiqian Chen
2025-05-18 14:34 ` Jan Beulich
2025-05-19 6:56 ` Chen, Jiqian
2025-05-19 13:07 ` Jan Beulich
2025-05-09 9:05 ` [PATCH v4 05/10] vpci: Hide legacy capability when it fails to initialize Jiqian Chen
2025-05-18 14:44 ` Jan Beulich
2025-05-19 7:35 ` Chen, Jiqian
2025-05-19 10:04 ` Roger Pau Monné
2025-05-09 9:05 ` [PATCH v4 06/10] vpci: Hide extended " Jiqian Chen
2025-05-18 14:47 ` Jan Beulich
2025-05-19 7:41 ` Chen, Jiqian
2025-05-19 13:12 ` Jan Beulich
2025-05-09 9:05 ` [PATCH v4 07/10] vpci: Refactor vpci_remove_register to remove matched registers Jiqian Chen
2025-05-19 6:30 ` Jan Beulich
2025-05-19 7:44 ` Chen, Jiqian
2025-05-19 10:24 ` Roger Pau Monné [this message]
2025-05-09 9:05 ` [PATCH v4 08/10] vpci/rebar: Remove registers when init_rebar() fails Jiqian Chen
2025-05-19 6:54 ` Jan Beulich
2025-05-19 7:49 ` Chen, Jiqian
2025-05-09 9:05 ` [PATCH v4 09/10] vpci/msi: Free MSI resources when init_msi() fails Jiqian Chen
2025-05-20 6:40 ` Jan Beulich
2025-05-20 9:09 ` Roger Pau Monné
2025-05-20 9:14 ` Jan Beulich
2025-05-20 9:43 ` Roger Pau Monné
2025-05-21 7:00 ` Chen, Jiqian
2025-05-21 11:23 ` Roger Pau Monné
2025-05-22 2:21 ` Chen, Jiqian
2025-05-22 7:12 ` Roger Pau Monné
2025-05-22 7:27 ` Chen, Jiqian
2025-05-09 9:05 ` [PATCH v4 10/10] vpci/msix: Add function to clean MSIX resources Jiqian Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsG3-u_3Gh4sm99@Mac.lan \
--to=roger.pau@citrix.com \
--cc=Jiqian.Chen@amd.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=ray.huang@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.