From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode
Date: Mon, 19 May 2025 14:18:36 +0300 [thread overview]
Message-ID: <aCsTjM49Ll2fcv4j@smile.fi.intel.com> (raw)
In-Reply-To: <20250519111311.2390-6-wsa+renesas@sang-engineering.com>
On Mon, May 19, 2025 at 01:13:12PM +0200, Wolfram Sang wrote:
> 'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C
> core handles them equally, so simply convert this driver to fwnode.
...
> - info.of_node = of_node_get(node);
> + info.fwnode = of_fwnode_handle(of_node_get(node));
What puzzles me here is that of_node_get(). We already do the same in the I²C
core, does it really need the second bump of the reference counting?
In any case, this patch doesn't change the status quo, I'm fine to leave the
research for the later.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-19 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 11:13 [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info Wolfram Sang
2025-05-19 11:13 ` [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode Wolfram Sang
2025-05-19 11:18 ` Andy Shevchenko [this message]
2025-05-19 11:25 ` Wolfram Sang
2025-05-19 22:03 ` Andi Shyti
2025-05-20 9:15 ` Wolfram Sang
2025-05-20 9:39 ` Andi Shyti
2025-05-19 11:13 ` [PATCH 2/3] i2c: use only 'fwnode' for client devices Wolfram Sang
2025-05-19 21:10 ` Andi Shyti
2025-05-19 11:13 ` [PATCH 3/3] i2c: remove 'of_node' member from i2c_boardinfo Wolfram Sang
2025-05-19 21:10 ` Andi Shyti
2025-05-19 11:19 ` [PATCH 0/3] i2c: remove 'of_node' from i2c_board_info Andy Shevchenko
2025-05-20 20:50 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsTjM49Ll2fcv4j@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.