From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7699D275110 for ; Mon, 19 May 2025 11:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747655065; cv=none; b=NutH7LQbp1Eu96EGmuAsos7LBI7XucfS/mJ3d0XF4WEayVl83D/8NlGHVccFYfg9USV6S5Nal4XQ6Sonjgj14dUVVW7EknX0bjXrLK3t9RWCqL3HQEUjzfZ0bZTsZkgGwKrcKkbiylHrydBlI40c6Ui+iVbwfhykfhhmiAyeTrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747655065; c=relaxed/simple; bh=L/SrPQXmwBivskgeVW69UuD0jXMmA4aDy5Tx2qNPU84=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CL6HTEM7bcrF9/wDednRuO+cBwJ9vlrLg8UQG/Ex18ajqG5OwBg2rSffgspAuriKJcpL8LnZK0xGzxdjHGbRyFmtp2AFawEyRcBXPsrq22YEpH/Z6ZPLNsq3h0FMSe4fjtugmHLmSdpifrvoxDYgPZk4Rl4OCxDMLVxLKt3smtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: gKSoX/1LSOKIiu5ybBgGdw== X-CSE-MsgGUID: FSmOPsomSSKSlU0eSy8dFg== X-IronPort-AV: E=McAfee;i="6700,10204,11437"; a="52181768" X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="52181768" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2025 04:44:24 -0700 X-CSE-ConnectionGUID: IuZwhEFpQSqTVQ+/XbsRgA== X-CSE-MsgGUID: SsPTwdF4QymSFc9iC4m6cA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,300,1739865600"; d="scan'208";a="140235549" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2025 04:44:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uGyup-000000031Nl-0ocg; Mon, 19 May 2025 14:44:19 +0300 Date: Mon, 19 May 2025 14:44:18 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 15/23] media: atomisp: gc0310: Switch to using the sub-device state lock Message-ID: References: <20250517114106.43494-1-hdegoede@redhat.com> <20250517114106.43494-16-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250517114106.43494-16-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sat, May 17, 2025 at 01:40:58PM +0200, Hans de Goede wrote: > Switch to using the sub-device state lock and properly call > v4l2_subdev_init_finalize() / v4l2_subdev_cleanup() on probe() / > remove(). Ah, cool! But can this patch be put before the previous one which adds some locking? -- With Best Regards, Andy Shevchenko