From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AB0EC2D0CD for ; Mon, 19 May 2025 15:34:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC7B110E3DD; Mon, 19 May 2025 15:34:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="b3RV5Eel"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id B390810E3E0 for ; Mon, 19 May 2025 15:34:15 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BA688629CA; Mon, 19 May 2025 15:34:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E39CBC4CEE9; Mon, 19 May 2025 15:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747668850; bh=DCOXc0NI85IirLGyEljEzY9WQiSNKDiEnqVOnUu/m3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b3RV5Eel0fRFAkNCz4y4TnLwMba2dLb2Z9V3fdlQQ01oIS0ksDvAylw8NW9GKVl2a O2/79xLZk9kPlrqpXdMvAQu91DNczO9c6ec2UIldFeR/xZSGngnGR229ZJhegd3qy2 55INKOWUdP2EJAhpMWpfot6Vw06zEI773hwPviEC6K62wAlcpho/DeZRdW3YVcuB72 S5KlrSck15l398iSRn1fFOR6lgjYo9tbSABI2YeXzC2JS1PWSeZIk8RF44OxXMiIlQ 0fMxCx62syEtDCT065nvjIYn3U/yz82gCbcSfKzSJhwUuR945JSnkkHHv7vVXVzcK7 sAROn48AzFrtQ== Date: Mon, 19 May 2025 17:34:05 +0200 From: Danilo Krummrich To: Pierre-Eric Pelloux-Prayer Cc: Matthew Brost , Philipp Stanner , Christian =?iso-8859-1?Q?K=F6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 03/10] drm/sched: add device name to the drm_sched_process_job event Message-ID: References: <20250424083834.15518-1-pierre-eric.pelloux-prayer@amd.com> <20250424083834.15518-4-pierre-eric.pelloux-prayer@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424083834.15518-4-pierre-eric.pelloux-prayer@amd.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 24, 2025 at 10:38:15AM +0200, Pierre-Eric Pelloux-Prayer wrote: > diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > index f56e77e7f6d0..713df3516a17 100644 > --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h > @@ -42,6 +42,7 @@ DECLARE_EVENT_CLASS(drm_sched_job, > __field(uint64_t, id) > __field(u32, job_count) > __field(int, hw_job_count) > + __string(dev, dev_name(sched_job->sched->dev)) Using the sched_job->sched pointer here and in other trace events implies that the trace event must not be called before the sched_job->sched has been set, i.e. in drm_sched_job_arm(). Please document this for the corresponding trace events.