From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E653F1E5701 for ; Mon, 19 May 2025 16:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747672483; cv=none; b=SSkuoepjh0qkgzUaqO+8nkC9bzuEO9k9OxUncceJ/NJ7NnZKxfWg9Cx+lxpWrpYwmNhBeqaGZs9OBluzxabsrTpOWre8CU9SgNc0yGH6R+NWTJsuH+tr3EB8QnNNm6JW274N9msk/7M3gZX9hZuyeQwTcC95GgVB83h2qMcp8F0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747672483; c=relaxed/simple; bh=HiNonMtdaAz5TQIcX+lq1jeBQ2cEztMYiD+glrCqktA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nTSzcSO+J5X3iuZt4KLZ+2dh0m2bxK0+rjerfuB3jMP2L+zhdaZQVOqnCls4uW0v8nH3OXQAK6fCf75p9QYCw/KiwCPbbs54xCsmThvkfaLNQuLnxUfw73/o+APcArbFNUk1pOMH3Kf4NHl9g1ZDM6vPv03Ck/VgPQrMffUk0No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FZW72mIb; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FZW72mIb" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30e9e8d3e85so3075804a91.1 for ; Mon, 19 May 2025 09:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747672480; x=1748277280; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8zv3GTZ1OQoWAPfijjQY1dYYsvZlBkqwnY1otuI5HeM=; b=FZW72mIbIQuzp36nN3i/VvCuZ/uZReNsePRa+yoChufQN2OobUEXwnWxLlHtOXsYWj 0dOBiEFAGYbQeIezPSzlj9uWNztmVCJbQxVrUOacd6/xbheIZRenJeBAmQfmTFQRDeUl SluEkv6MptjrWNbRUoAiG0CEz2/iya9oK1LE6Ei5vTUyLPJoDAh/ct60Sv7snbASPGq2 bqIa1Jg99kCKM3PhApDBv6aIWTGN/UtzgoDaVf6spI8FBVyo/KggJjGLcGj2Av0t/kRn DDC1vLz/flTPhRk9HHD8NyHQfP9acLrBJ8YII3ZMraqEHdJo3V4GyAH33efrrNkAx5cn hSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747672480; x=1748277280; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8zv3GTZ1OQoWAPfijjQY1dYYsvZlBkqwnY1otuI5HeM=; b=o3Wh1G/q9tMrMDxc2uz6Rrll1zvK7aIVgn2K2OnD3zOJrM314HdPUIteSEik+IJffp dYPtw5mNw70IuK9qbLez3Kj/sNDcy3hiC+jrDS7clQqg7VLPGvnVyculZXKYQbXDNBE7 w/pUxHU8wsNs3ofwS/6JnhWvvr6KB1Ch36oKjmm0d0lnHAvxrQ/ceh9tBE3NTmRgUP5f 9f39slRAzkfTCGe5aCWlV8tB5COm1ul/QJIKvSwwWavKanfOQWVmIq41QPSkASsyhz2Z 3mR8OqDzYLOQhikYzhDX3BHYu2PyBLZmowVT66gNPNu8Wt2vCnlHWPhhO8T1aExlLH4H X+pA== X-Forwarded-Encrypted: i=1; AJvYcCVcNmkHugc74F+Z7lhtUrjW/B7+pHsBdG2KwqcKb2oLDkjoXzDk1VHxxNeYrhC+lijfYUE=@vger.kernel.org X-Gm-Message-State: AOJu0YzNUuGnYCYdwhVS2vrjvhjkFzDDCJOCPv7kcrMolb4vLDnVI568 B2OxbUvKrSeJdZGFhAL2GQLU4WVqbu5ltED7oJ/yPUiejJodLukFVqorU+pqEfI1DdfNE5fTDck HmlOnPA== X-Google-Smtp-Source: AGHT+IF7Pp0SGv2aGgzlEI/adpem8+WPZlHOMtK6iV/1Zu8WqJx6oDl5Gz/qVNTkZFz9jTihYXpZXJvKkyk= X-Received: from pjbsw16.prod.google.com ([2002:a17:90b:2c90:b0:2ff:84e6:b2bd]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d4c:b0:301:1c11:aa74 with SMTP id 98e67ed59e1d1-30e7d5a84a3mr22376515a91.28.1747672480225; Mon, 19 May 2025 09:34:40 -0700 (PDT) Date: Mon, 19 May 2025 09:34:38 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250516212833.2544737-1-seanjc@google.com> <20250516212833.2544737-8-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 7/8] x86, lib: Add wbinvd and wbnoinvd helpers to target multiple CPUs From: Sean Christopherson To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Paolo Bonzini , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Zheyun Shen , Tom Lendacky , Kevin Loughlin , Kai Huang , Mingwei Zhang Content-Type: text/plain; charset="us-ascii" On Sat, May 17, 2025, Ingo Molnar wrote: > > * Sean Christopherson wrote: > > > From: Zheyun Shen > > > > Extract KVM's open-coded calls to do writeback caches on multiple CPUs to > > common library helpers for both WBINVD and WBNOINVD (KVM will use both). > > Put the onus on the caller to check for a non-empty mask to simplify the > > SMP=n implementation, e.g. so that it doesn't need to check that the one > > and only CPU in the system is present in the mask. > > > > Signed-off-by: Zheyun Shen > > Reviewed-by: Tom Lendacky > > Link: https://lore.kernel.org/r/20250128015345.7929-2-szy0127@sjtu.edu.cn > > [sean: move to lib, add SMP=n helpers, clarify usage] > > Acked-by: Kai Huang > > Signed-off-by: Sean Christopherson > > --- > > arch/x86/include/asm/smp.h | 12 ++++++++++++ > > arch/x86/kvm/x86.c | 8 +------- > > arch/x86/lib/cache-smp.c | 12 ++++++++++++ > > 3 files changed, 25 insertions(+), 7 deletions(-) > > > > diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h > > index e08f1ae25401..fe98e021f7f8 100644 > > --- a/arch/x86/include/asm/smp.h > > +++ b/arch/x86/include/asm/smp.h > > @@ -113,7 +113,9 @@ void native_play_dead(void); > > void play_dead_common(void); > > void wbinvd_on_cpu(int cpu); > > void wbinvd_on_all_cpus(void); > > +void wbinvd_on_many_cpus(struct cpumask *cpus); > > void wbnoinvd_on_all_cpus(void); > > +void wbnoinvd_on_many_cpus(struct cpumask *cpus); > > Let's go with the _on_cpumask() suffix: > > void wbinvd_on_cpu(int cpu); > +void wbinvd_on_cpumask(struct cpumask *cpus); > void wbinvd_on_all_cpus(void); How about wbinvd_on_cpus_mask(), to make it more obvious that it operates on multiple CPUs? At a glance, wbinvd_on_cpumask() could be mistaken for a masked version of wbinvd_on_cpu().