From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22D94C2D0CD for ; Mon, 19 May 2025 16:37:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3U6-00021V-LS; Mon, 19 May 2025 12:37:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3Tz-000206-UN for qemu-devel@nongnu.org; Mon, 19 May 2025 12:36:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3Tx-0005f5-81 for qemu-devel@nongnu.org; Mon, 19 May 2025 12:36:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747672610; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t5U0g1KAyGOcioaRFSO+2C4rD5gsRm3hs9ktjY+L0sk=; b=W9HRnJ2KDhVVaTQk1pnUegYoERzSdRI5//WUGD41p5wKdiFsU6RJV+YNl/qi26HFUQNLow vqp/ACoIXUZjbz8WupnlSmN3stezo2Z7rrGdr7OLdiMsYrRFAkHloo+9Ce7RGjZxWwkNAB noujFgKiKPrApq/I9Ymk/5GAgvssM3w= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-L41pLlCUM16e2MaaNNI-gQ-1; Mon, 19 May 2025 12:36:47 -0400 X-MC-Unique: L41pLlCUM16e2MaaNNI-gQ-1 X-Mimecast-MFC-AGG-ID: L41pLlCUM16e2MaaNNI-gQ_1747672606 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B72E8195608E; Mon, 19 May 2025 16:36:45 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.50]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72211180049D; Mon, 19 May 2025 16:36:43 +0000 (UTC) Date: Mon, 19 May 2025 17:36:39 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: qemu-devel@nongnu.org, Peter Maydell , =?utf-8?Q?C=C3=A9dric?= Le Goater , =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH v3 2/9] scripts/checkpatch.pl: fix various indentation mistakes Message-ID: References: <20250515135936.86760-1-berrange@redhat.com> <20250515135936.86760-3-berrange@redhat.com> <87ldqsr2fq.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ldqsr2fq.fsf@draig.linaro.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, May 19, 2025 at 05:27:21PM +0100, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > Various checks in the code were under-indented relative to other > > surrounding code. > > Are we accepting that we have hard forked from the Linux checkpatch now? The changed lines were all in QEMU specific checks, so don't make that situation any worse than it already is. AFAICT, we've got so many add-ons that we're a quite significant fork already. It may be possible to merge back changes from Linux still, but I wouldn't want to be the one figuring out that resolution :-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|