From: Brian Norris <briannorris@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Tsai Sung-Fu <danielsftsai@google.com>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3] genirq: Add kunit tests for depth counts
Date: Mon, 19 May 2025 15:59:30 -0700 [thread overview]
Message-ID: <aCu30rOFY5vL1AU6@google.com> (raw)
In-Reply-To: <202505172307.yTjulMhx-lkp@intel.com>
On Sun, May 18, 2025 at 12:13:47AM +0800, kernel test robot wrote:
> config: arm64-randconfig-001-20250517 (https://download.01.org/0day-ci/archive/20250517/202505172307.yTjulMhx-lkp@intel.com/config)
Ugh, that config manages to have this combination:
CONFIG_IRQ_KUNIT_TEST=y
CONFIG_KUNIT=m
I assumed that "IRQ_KUNIT_TEST depends on KUNIT" would rule out that
combination, but I see that's not true. I feel like I relearn Kconfig's
language every time I step outside the simplest of dependencies.
> >> ld.lld: error: undefined symbol: kunit_binary_ptr_assert_format
> >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
> >>> kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
> >>> referenced by irq_test.c:54 (kernel/irq/irq_test.c:54)
> >>> kernel/irq/irq_test.o:(irq_disable_depth_test) in archive vmlinux.a
> >>> referenced by irq_test.c:81 (kernel/irq/irq_test.c:81)
> >>> kernel/irq/irq_test.o:(irq_free_disabled_test) in archive vmlinux.a
> >>> referenced 5 more times
> --
> >> ld.lld: error: undefined symbol: kunit_try_catch_throw
> >>> referenced by irq_test.c:0 (kernel/irq/irq_test.c:0)
> >>> kernel/irq/irq_test.o:(irq_cpuhotplug_test) in archive vmlinux.a
I guess I'll need to squash this in:
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -146,7 +146,7 @@ config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
config IRQ_KUNIT_TEST
bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS
- depends on KUNIT
+ depends on KUNIT=y
default KUNIT_ALL_TESTS
imply SMP
help
I'll sit on it and send v4 eventually.
Brian
prev parent reply other threads:[~2025-05-19 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 18:30 [PATCH v3] genirq: Add kunit tests for depth counts Brian Norris
2025-05-17 16:13 ` kernel test robot
2025-05-19 22:59 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCu30rOFY5vL1AU6@google.com \
--to=briannorris@chromium.org \
--cc=danielsftsai@google.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.