From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E9C647; Tue, 20 May 2025 09:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747732635; cv=none; b=PbFMPui4YbBzSClY2dyllTCY9DVCDRayfoK95ynrh5DFJAElRB2rhj0pJ3mwa5Q4AOgfAIOKcWd7hHNV2Brzh+QKEBWhHi4MqXPVFuq88VNfU/PGEdZiHUXRxbOtK37I6wVwNG42cHyEHhIEULrWjs7TwF938M4kyy5rMzyLq7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747732635; c=relaxed/simple; bh=BhrwYR9Bpw5TY8cvWbegmzVkfmOOpNoCkTqfQfjj81A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LLrbQUjA5C2dhe5IlgqGhxYGwvk9HLMHR7m75o7LXtqpChHTnCdv962+gS53FqJ4gyndqBYXeAq2miPp15Tuo1XJsLLT8s/KWzw6yvZbTTbZ0hUGY+hGjSWlKuKbqGWdktySkMfXE11qOswzKx0UapxJA8AVKvQLlikHT0xYsFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c1Ea/sjV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c1Ea/sjV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75782C4CEE9; Tue, 20 May 2025 09:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747732634; bh=BhrwYR9Bpw5TY8cvWbegmzVkfmOOpNoCkTqfQfjj81A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c1Ea/sjVdrTFuG7y7I0ieQGNx21uUgP4RgkC9wJXvN22g6sOi6sR15D/6+8dYkTh8 xilTfUIhrvRjwwYD2UrXQyQ4ACFIvY8akHrltM1VQDdMF0eUwYLXKn5y9FzQvRToO1 nltIqgzkvi6peYbdC4ebehQJxNV5RqPfhU/rG9JJeBYgTFU+e+k99ZabUYY4MIpwA9 t9zPPoITlYNl8YHQQmU2jtuGz5AAS/GRlIo325D5KyLK4x8zEvoWmVg58W5cBrqpBO jV1aCW4FJdOKkDqu9+Ew2FF+W+vmXMIh8BVsvOihKK1uJa8Q/MO5kjOA44fXxosHvA Z8gq5HN3TeSwA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1uHJ5y-000000002o0-0OPB; Tue, 20 May 2025 11:17:10 +0200 Date: Tue, 20 May 2025 11:17:10 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Bryan O'Donoghue , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version Message-ID: References: <3e34ce09-1207-4dba-bff8-38c01cad9b78@linaro.org> <4d942a6c-cbff-41ac-af8b-12a1ff5181aa@linaro.org> <883eb54a-fcaf-443c-a4d7-e1278fd43f5a@linaro.org> <190100e7-8a59-4cf3-8434-bcb6292cacb2@linaro.org> <8a2f2269-d07f-42b2-ab6c-dcff30a1f431@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 20, 2025 at 10:51:56AM +0200, Krzysztof Kozlowski wrote: > On 20/05/2025 10:44, Bryan O'Donoghue wrote: > > I find the debug prints useful in that I know the hardware block has > > been powered on, clocked etc. I agree the number of those prints seems > > excessive. > > > > The reason it is printed out multiple time is the blocks get powered on/off. > > > > Personally I agree with Johan - it would be nice/useful to print it out > > once with DEBUG on, so that we know we have successfully powered-on and > > That's opposite to what coding style asks. Success should be silent. The coding style says probe should be silent, but debug statements are not printed by default so that bit does not apply here. Johan