From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next,v2 2/2] netfilter: nf_tables: honor validation state in preparation phase
Date: Tue, 20 May 2025 12:34:00 +0200 [thread overview]
Message-ID: <aCxamGnvNai00dwU@strlen.de> (raw)
In-Reply-To: <20250520092029.190588-2-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> static int nft_table_validate(struct net *net, const struct nft_table *table)
> @@ -4044,6 +4060,7 @@ static int nft_table_validate(struct net *net, const struct nft_table *table)
> struct nft_chain *chain;
> struct nft_ctx ctx = {
> .net = net,
> + .table = (struct nft_table *)table,
Patch LGTM but I think it would make more sense to remove the const
qualifier from nft_table_validate() rather than this un-do.
Aside from that:
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2025-05-20 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 9:20 [PATCH nf-next,v2 1/2] netfilter: nf_tables: honor EINTR in ruleset validation from commit/abort path Pablo Neira Ayuso
2025-05-20 9:20 ` [PATCH nf-next,v2 2/2] netfilter: nf_tables: honor validation state in preparation phase Pablo Neira Ayuso
2025-05-20 10:34 ` Florian Westphal [this message]
2025-05-20 10:29 ` [PATCH nf-next,v2 1/2] netfilter: nf_tables: honor EINTR in ruleset validation from commit/abort path Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCxamGnvNai00dwU@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.