From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BE6DC5B543 for ; Wed, 4 Jun 2025 03:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=utnTxuh7qOwL7AXzOpsK3TSF8i00Q+CFtxzReOjp1mU=; b=wSs+CRDoASwIpz+JnQA2b2ZL2w jmdUPfW4d1nzVg5Wt3lcl3OJbaNUIT/3YjJz4MMOKnSyQ8n68R+Pw3iFozNGdTWzXHYnEntnhg+C2 pK2Cbc7QmP6I+xil49FAaBb3rbs6e6+donjV4F3YlmOd39KGefneB5Mo/Uk10E7mhXLYA13sKFBlV ZEGb9WZlnwzGK2HAnVRcVJPRlBkJ2HJR9aWVsIiehf2uQ3ltQ4zUE6Ov1tMPTU5l3rYCXIsMfG3TI ozsals+90HbB5CcQU0gnvkoHgpC7Ji/Q+kxiPGUORK1hOcfDdb1vrSkCkzrk/2IbTeSHXgzx8Kmjv fZzD67Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMend-0000000CRkn-2j5A; Wed, 04 Jun 2025 03:28:21 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMcaN-0000000C92T-1Odv for linux-riscv@lists.infradead.org; Wed, 04 Jun 2025 01:06:33 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-afc857702d1so4813956a12.3 for ; Tue, 03 Jun 2025 18:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1748999190; x=1749603990; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LhHMc55NRcsN/FvPE9B87wOrlUj3VF0MtSHgMnAPDz4=; b=xrNpbBWwnEL9C9GMRiL85UgX9mTbTyVypsbmkrfXu18MWXQ08REtG8+iK8IEJQ1gBv Zr5GO0S/7Lv9yxbSr8aNtNmMvu/eDqqn3zE+6OkZPHa67zUsybUgNu+t1NSPzQikpLpp FsEKfa6sfKIUXnS5X6cp8Z9vLsZT6GNw0ygTDH+MiifoK72mf/2UXaXXN85GCR4oHYT9 TSxTEowjUwvSmKcaOrV8rBMBIPABZLzearbuFSdOfyYVNvqzfQufb6p6RYnW0IlA8Igb xBal4vXmUbIH7C22Fy2Fh2Hjv5lqrOkSEgRuwv9FJt0q6CmFONoij2O07qd6uhwGBC9s W0iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748999190; x=1749603990; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LhHMc55NRcsN/FvPE9B87wOrlUj3VF0MtSHgMnAPDz4=; b=F/FS2AGxb7NcXC61e+igHK2ysHg1H4ePOLhpCbJx8brs3Fh+0sdWQxPihFRNzkvtS6 iGNOo7VJ5os4hux1TAHsHBUjvVHypbzMAmF7nLpsnim6R0hvOQFssxlOTLB9Ygu6NI7L LnSIeAx/oAppWUPoMf7RbCb4SuQU3YT77iHz0uLRdlJcL7kQVDjHMtv7UV0ggLEg8xpU PvcYS/4ah92lZA2QKE7sgp1CSxosszH/m973b01yyK5tdLYuClTU80arFiHENxA+D0wx G1jgVTiAXjD/ujE5qrTYQVTJptZigwCTCLR3vhHRl+30MKFtJUM8ZKYvoJgILgnddjVJ 6uiA== X-Forwarded-Encrypted: i=1; AJvYcCWxBsQ3TxgxaaqP1UUT7Ogp777QE5far/Lnm3C2cXeDq77LB8qW7ldmyS61+gzYd0OuCDcOqllHjdf86g==@lists.infradead.org X-Gm-Message-State: AOJu0YxMeFro5qiHiRZwil9BB53tDiXeSgXVantziJcGUAisnetiRfXw zSE/2TvRcj5a8cL3Btm9qAlernRta/afzdKim+zdInph0ZmAR6jMUeyX0eDyHKfJ/XC9zDJxXPa CwVvn X-Gm-Gg: ASbGncu5Np9YH9L3fXp3fHxNAQ1VypHxeZhtWDVNZAoVMvDK5wUmGrq9Qf/Ydko9BoT 2crKuk/0yAWqOwFtprMbhnpL0I3aHCr4TOLk2bCHKrWP7NC03/PVIQcZ1U41yC89tCFepsfNcon qHPb5A4Uh5N5gyBQzGRHCn8Y0yL2hyOesv+IjHMooAt1hZwwfUFuW0w3Jrwu8pxMqQiMCei9tFI o7Vifpev4MKGNQ1UzNSXNbKlB4x/7iyFE40u2w1GsCUDsLq28MntBGMLLgEvwUw15L+kXBak+LU JdgT4lDqtVn//6O7Pjet6BX+SfXbKafAZOXN8SQfV+QG7kVtrbpWzC+qkWoQEA== X-Google-Smtp-Source: AGHT+IFvTALfjp/Y3ibakB8CWPTcZ35xraSu/LuIlBzY9vBaddLzmcMTcOCjwa9SRy36GVF16/VEAg== X-Received: by 2002:a17:90a:da87:b0:311:e8cc:4253 with SMTP id 98e67ed59e1d1-3130ccf5106mr1396296a91.2.1748999189904; Tue, 03 Jun 2025 18:06:29 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e2e9262sm7890955a91.27.2025.06.03.18.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 18:06:29 -0700 (PDT) Date: Tue, 3 Jun 2025 18:06:27 -0700 From: Deepak Gupta To: Zong Li Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: traps: handle uprobe event in software-check exception Message-ID: References: <20250314092614.27372-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250603_180631_612226_22A2C8BA X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMDMsIDIwMjUgYXQgMDk6NDg6MDhBTSArMDgwMCwgWm9uZyBMaSB3cm90ZToK Pk9uIFR1ZSwgSnVuIDMsIDIwMjUgYXQgMTI6NTDigK9BTSBEZWVwYWsgR3VwdGEgPGRlYnVnQHJp dm9zaW5jLmNvbT4gd3JvdGU6Cj4+Cj4+IEhpIFpvbmcsCj4+Cj4+IFRoYW5rcyBmb3IgdGFraW5n IHRoZSBpbml0aWF0aXZlIGZvciBtYWtpbmcgY2ZpIHdvcmsgd2l0aCB1cHJvYmUuCj4+IEFuZCBz b3JyeSBmb3Igbm90IG5vdGljaW5nIHRoZSBwYXRjaCBlYXJsaWVyLgo+PiBGZXcgY29tbWVudHMg aW5saW5lLgo+Pgo+Pgo+PiBPbiBGcmksIE1hciAxNCwgMjAyNSBhdCAwNToyNjoxNFBNICswODAw LCBab25nIExpIHdyb3RlOgo+PiA+SGFuZGxlIHRoZSB1cHJvYmUgZXZlbnQgZmlyc3QgYmVmb3Jl IGhhbmRsaW5nIHRoZSBDRkkgdmlvbGF0aW9uIGluCj4+ID5zb2Z0d2FyZS1jaGVjayBleGNlcHRp b24gaGFuZGxlci4gQmVjYXVzZSB3aGVuIHRoZSBsYW5kaW5nIHBhZCBpcwo+PiA+YWN0aXZhdGVk LCBpZiB0aGUgdXByb2JlIHBvaW50IGlzIHNldCBhdCB0aGUgbHBhZCBpbnN0cnVjdGlvbiBhdAo+ PiA+dGhlIGJlZ2lubmluZyBvZiBhIGZ1bmN0aW9uLCB0aGUgc3lzdGVtIHRyaWdnZXJzIGEgc29m dHdhcmUtY2hlY2sKPj4gPmV4Y2VwdGlvbiBpbnN0ZWFkIG9mIGFuIGVicmVhayBleGNlcHRpb24g ZHVlIHRvIHRoZSBleGNlcHRpb24KPj4gPnByaW9yaXR5LCB0aGVuIHVwcm9iZSBjYW4ndCB3b3Jr IHN1Y2Nlc3NmdWxseS4KPj4gPgo+PiA+Q28tZGV2ZWxvcGVkLWJ5OiBEZWVwYWsgR3VwdGEgPGRl YnVnQHJpdm9zaW5jLmNvbT4KPj4gPlNpZ25lZC1vZmYtYnk6IERlZXBhayBHdXB0YSA8ZGVidWdA cml2b3NpbmMuY29tPgo+PiA+U2lnbmVkLW9mZi1ieTogWm9uZyBMaSA8em9uZy5saUBzaWZpdmUu Y29tPgo+PiA+LS0tCj4+ID4KPj4gPlRoaXMgcGF0Y2ggaXMgYmFzZWQgb24gdG9wIG9mIHRoZSBm b2xsb3dpbmcgc2VyaWVzCj4+ID5bUEFUQ0ggdjExIDAwLzI3XSByaXNjdiBjb250cm9sLWZsb3cg aW50ZWdyaXR5IGZvciB1c2VybW9kZQo+PiA+Cj4+ID4gYXJjaC9yaXNjdi9rZXJuZWwvdHJhcHMu YyB8IDkgKysrKysrLS0tCj4+ID4gMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPj4gPgo+PiA+ZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVsL3RyYXBz LmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC90cmFwcy5jCj4+ID5pbmRleCAzZjc3MDlmNDU5NWEuLmVm NWE5MjExMWVlMSAxMDA2NDQKPj4gPi0tLSBhL2FyY2gvcmlzY3Yva2VybmVsL3RyYXBzLmMKPj4g PisrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3RyYXBzLmMKPj4gPkBAIC0zODYsOSArMzg2LDEyIEBA IGFzbWxpbmthZ2UgX192aXNpYmxlIF9fdHJhcF9zZWN0aW9uIHZvaWQgZG9fdHJhcF9zb2Z0d2Fy ZV9jaGVjayhzdHJ1Y3QgcHRfcmVncyAqCj4+ID4gICAgICAgaWYgKHVzZXJfbW9kZShyZWdzKSkg ewo+PiA+ICAgICAgICAgICAgICAgaXJxZW50cnlfZW50ZXJfZnJvbV91c2VyX21vZGUocmVncyk7 Cj4+ID4KPj4gPi0gICAgICAgICAgICAgIC8qIG5vdCBhIGNmaSB2aW9sYXRpb24sIHRoZW4gbWVy Z2UgaW50byBmbG93IG9mIHVua25vd24gdHJhcCBoYW5kbGVyICovCj4+ID4tICAgICAgICAgICAg ICBpZiAoIWhhbmRsZV91c2VyX2NmaV92aW9sYXRpb24ocmVncykpCj4+ID4tICAgICAgICAgICAg ICAgICAgICAgIGRvX3RyYXBfdW5rbm93bihyZWdzKTsKPj4gPisgICAgICAgICAgICAgIC8qIGhh bmRsZSB1cHJvYmUgZXZlbnQgZnJpc3QgKi8KPj4gPisgICAgICAgICAgICAgIGlmICghcHJvYmVf YnJlYWtwb2ludF9oYW5kbGVyKHJlZ3MpKSB7Cj4+Cj4+IElmIHRhc2sgaGFzIHVwcm9iZSBlbmFi bGVkIGFuZCB0aGVyZSBpcyBhIGNmaSB2aW9sYXRpb24gZHVlIHRvIG1pc21hdGNoIGluCj4+IHJl dHVybiBhZGRyZXNzIG9uIHNoYWRvdyBzdGFjayBhbmQgcmVndWxhciBzdGFjaywgdGhlbiBpdCB3 b3VsZCBiZSBhIGNmaQo+PiBieXBhc3MsIHJpZ2h0Pwo+PiBQZXJoYXBzIHdlIHNob3VsZCBiZSBk b2luZyB0aGlzIG9ubHkgd2hlbiB3ZSBtYXRjaCB0aGF0IHN3IGNoZWNrIGV4Y2VwdGlvbgo+PiBp cyBkdWUgdG8gZm9yd2FyZCBjZmkgdmlvbGF0aW9uPwo+Pgo+PiBEbyB5b3UgYWdyZWU/Cj4KPlll cywgbGV0IG1lIGFkZCBhIGNvbmRpdGlvbiBmb3IgZm9yd2FyZCBjZmkgdmlvbGF0aW9uIGhlcmUu IFRoYW5rcyBmb3IKPnBvaW50aW5nIGl0IG91dC4KCkNvb2wsIEknbGwgc2VuZCBvdXQgYW5vdGhl ciByZXZpc2lvbiBmb3IgbXkgY2ZpIHNlcmllcyB0aGlzIHdlZWsuCklmIHlvdSBzZW5kIG91dCB5 b3VyIHVwcm9iZSBmaXgsIEkgY2FuIGluY2x1ZGUgaXQgaW4gbXkgcGF0Y2hzZXQuCgo+Cj4+Cj4+ ID4rICAgICAgICAgICAgICAgICAgICAgIC8qIG5vdCBhIGNmaSB2aW9sYXRpb24sIHRoZW4gbWVy Z2UgaW50byBmbG93IG9mIHVua25vd24gdHJhcCBoYW5kbGVyICovCj4+ID4rICAgICAgICAgICAg ICAgICAgICAgIGlmICghaGFuZGxlX3VzZXJfY2ZpX3Zpb2xhdGlvbihyZWdzKSkKPj4gPisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkb190cmFwX3Vua25vd24ocmVncyk7Cj4+ID4rICAg ICAgICAgICAgICB9Cj4+ID4KPj4gPiAgICAgICAgICAgICAgIGlycWVudHJ5X2V4aXRfdG9fdXNl cl9tb2RlKHJlZ3MpOwo+PiA+ICAgICAgIH0gZWxzZSB7Cj4+ID4tLQo+PiA+Mi4xNy4xCj4+ID4K Pj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4g bGludXgtcmlzY3YgbWFpbGluZyBsaXN0Cj4+IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5v cmcKPj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y aXNjdgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B68E6274FEA for ; Wed, 4 Jun 2025 01:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748999193; cv=none; b=KtBVWL1ZD2irW+lSr5tM3DzC7NwaNUE4Av1I/NslhZD09v5BuZmbSnsZRepvKyUV+yIf8gLvEreMqT2lcYSJmj8Ob7IhlPloz/XOpbZD437K6NuC3QkDdhHbJ2jahDy6rjyxFurgNOAd50lA401fYZmZCwBxp6G0yiMrbDLY2m0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748999193; c=relaxed/simple; bh=IQVVm2xw/bzq7dRFtzdHXISHByqKzowllZ0anTotjhA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hiqtMK4qRreJKpRbkyrmcbGmJFN0FxtTGF1KJuToEjLOruEqcBacbygT3MyLaEHVrem4ddWpNLPfEm0aEBdvQlDC8mHpOivc1KlubelPjWMw1uS+XYc2nh+qDi3rxH7pU5g89Pj9bKoir4CV9qqxXJAM+lWV01dfFTXzG50POAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=c8vli8My; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="c8vli8My" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b26d7ddbfd7so6424356a12.0 for ; Tue, 03 Jun 2025 18:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1748999190; x=1749603990; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LhHMc55NRcsN/FvPE9B87wOrlUj3VF0MtSHgMnAPDz4=; b=c8vli8MyEe8l2a0DR0XNegz6yakVCON8KoZR8aFgg0WeMYKfLSvtHJvTQHf75lU+N3 wNtjuA4HUSGFVxOsbq7QfSd9L2+yuZFbRxDvSJgAYERJPlkU4FgDadcu4Z7v+HFzanCt Zuj4LMl4ZiAgdTp4++qaRUOlTL567JIvTux4r5b7lh24f5zSAUVf49kgaWmozQ862+5K fjygTQc6afqAg5/IT7fYKGTiOzrCiLFzqcp5Xnp81qGvp1xfGTuDashjqnsHHhQ14Lsv uLgaTonDlQo5J8xneb/iMLylXU5JC5fLMfh9rOMpuCVTMmUSqW0dgDNRijZxr4e6vEQg IkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748999190; x=1749603990; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LhHMc55NRcsN/FvPE9B87wOrlUj3VF0MtSHgMnAPDz4=; b=j80v86YQK0WyqjuiyfPNSAbinOjvewcQ8yN6UgkIUmJZcwxUGbF5CscyYBKg47TQM/ lDNAi5cPG+RyPaRZLfa9Ik3pnhpY76NG8kjI1V46ujyHkhTI8SVTZkiWgBUtqWMy5VOo k5hMkwrThLDASdv2920PY//7fLauctYK3MnCJCzUq0FFsKBr4TB7a+iQIm8a7ybSc7ip HD+VX/SybaK6Ut+qg/QljtrtwVI4mLooweRL2N7D6GKSbrmH43AVbHzVvTnuEhcCSkgV i4ypcgRETq0DI/EhOhMGVYpsIwj353letqy3vDAfabLJSheOxQtCVAK3PJlYkGMTXkUp AVBw== X-Forwarded-Encrypted: i=1; AJvYcCWa6qN/yOoBl9mz4sCvGcNvrvuVu3mrbt65l7M5GdA5v41RRqldBQCFO3GGgXqU97OzIX7kJ2oTmm9yDj8=@vger.kernel.org X-Gm-Message-State: AOJu0YyYJ9lTcOQFcSuGrynTADakunFBkV1hoF2Qo5Ze662u7vJm1an+ 88xuDjoXZxc57i3PUZRCEoY8JnTE4euz93jYCEXPqNZA9W+w87Nfd+9bJZBJHr1Oe2M= X-Gm-Gg: ASbGncs9WzpIF1Dwpn+939FGZlnuPrMPEgdm+ixzLGlJ2vIqtPbe84Uw1yFJQAA4qGD 4I+/MWeCSYYJlaMGg0sOSeaetkR18/YGQJQd1T5vfJiwUBlgQwvJrPfduu1pskWRYYVvFRQ3aHG QEqqQwaXbVzki6pOB0mNrsItFC0eMpQ799ljUoIv84ANaEo2lOqsSCFrKH3dWySxgsxs8h4CVa+ wGUh4mxvbTpCcmpwhdrlKCfGdXYLmdiv2koh2Sx3PhzwDiR0ne4jJyNzlxYn4wgAx9DcxywGdlZ fJB7JudHqDBDuhO0kunsA+B6yXZ4Js4p/UJX89KYom/5Yuz1qfyeoj742Ho93g== X-Google-Smtp-Source: AGHT+IFvTALfjp/Y3ibakB8CWPTcZ35xraSu/LuIlBzY9vBaddLzmcMTcOCjwa9SRy36GVF16/VEAg== X-Received: by 2002:a17:90a:da87:b0:311:e8cc:4253 with SMTP id 98e67ed59e1d1-3130ccf5106mr1396296a91.2.1748999189904; Tue, 03 Jun 2025 18:06:29 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e2e9262sm7890955a91.27.2025.06.03.18.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 18:06:29 -0700 (PDT) Date: Tue, 3 Jun 2025 18:06:27 -0700 From: Deepak Gupta To: Zong Li Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: traps: handle uprobe event in software-check exception Message-ID: References: <20250314092614.27372-1-zong.li@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jun 03, 2025 at 09:48:08AM +0800, Zong Li wrote: >On Tue, Jun 3, 2025 at 12:50 AM Deepak Gupta wrote: >> >> Hi Zong, >> >> Thanks for taking the initiative for making cfi work with uprobe. >> And sorry for not noticing the patch earlier. >> Few comments inline. >> >> >> On Fri, Mar 14, 2025 at 05:26:14PM +0800, Zong Li wrote: >> >Handle the uprobe event first before handling the CFI violation in >> >software-check exception handler. Because when the landing pad is >> >activated, if the uprobe point is set at the lpad instruction at >> >the beginning of a function, the system triggers a software-check >> >exception instead of an ebreak exception due to the exception >> >priority, then uprobe can't work successfully. >> > >> >Co-developed-by: Deepak Gupta >> >Signed-off-by: Deepak Gupta >> >Signed-off-by: Zong Li >> >--- >> > >> >This patch is based on top of the following series >> >[PATCH v11 00/27] riscv control-flow integrity for usermode >> > >> > arch/riscv/kernel/traps.c | 9 ++++++--- >> > 1 file changed, 6 insertions(+), 3 deletions(-) >> > >> >diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c >> >index 3f7709f4595a..ef5a92111ee1 100644 >> >--- a/arch/riscv/kernel/traps.c >> >+++ b/arch/riscv/kernel/traps.c >> >@@ -386,9 +386,12 @@ asmlinkage __visible __trap_section void do_trap_software_check(struct pt_regs * >> > if (user_mode(regs)) { >> > irqentry_enter_from_user_mode(regs); >> > >> >- /* not a cfi violation, then merge into flow of unknown trap handler */ >> >- if (!handle_user_cfi_violation(regs)) >> >- do_trap_unknown(regs); >> >+ /* handle uprobe event frist */ >> >+ if (!probe_breakpoint_handler(regs)) { >> >> If task has uprobe enabled and there is a cfi violation due to mismatch in >> return address on shadow stack and regular stack, then it would be a cfi >> bypass, right? >> Perhaps we should be doing this only when we match that sw check exception >> is due to forward cfi violation? >> >> Do you agree? > >Yes, let me add a condition for forward cfi violation here. Thanks for >pointing it out. Cool, I'll send out another revision for my cfi series this week. If you send out your uprobe fix, I can include it in my patchset. > >> >> >+ /* not a cfi violation, then merge into flow of unknown trap handler */ >> >+ if (!handle_user_cfi_violation(regs)) >> >+ do_trap_unknown(regs); >> >+ } >> > >> > irqentry_exit_to_user_mode(regs); >> > } else { >> >-- >> >2.17.1 >> > >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv