Re: [PATCH net] netconsole: Only register console drivers when targets are configured

[Breno Leitao <leitao@debian.org>]

Hello Jakub,

On Fri, May 30, 2025 at 07:30:52PM -0700, Jakub Kicinski wrote:
> On Wed, 28 May 2025 10:20:19 -0700 Breno Leitao wrote:
> > The netconsole driver currently registers the basic console driver
> > unconditionally during initialization, even when only extended targets
> > are configured. This results in unnecessary console registration and
> > performance overhead, as the write_msg() callback is invoked for every
> > log message only to return early when no matching targets are found.
> > 
> > Optimize the driver by conditionally registering console drivers based
> > on the actual target configuration. The basic console driver is now
> > registered only when non-extended targets exist, same as the extended
> > console. The implementation also handles dynamic target creation through
> > the configfs interface.
> > 
> > This change eliminates unnecessary console driver registrations,
> > redundant write_msg() callbacks for unused console types, and associated
> > lock contention and target list iterations. The optimization is
> > particularly beneficial for systems using only the most common extended
> > console type.
> > 
> > Fixes: e2f15f9a79201 ("netconsole: implement extended console support")
> 
> Code makes sense but I think it's net-next material.

Sure, let me resend it (with the other patches) to net-next.

Thanks for the review,
--breno