From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1E0238174; Mon, 2 Jun 2025 14:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876349; cv=none; b=OjO23n7Ld9QvRK/BXNkMOGeRUt/mgEq6sg0ttPys9w+08lW2DV4U1UL/Okcv0O3vTYYhTjzyO2bDCTT6nKhLwAjvxBQICX/kkKkbNch3LqETNClUYotLeBbHka+0i99qk0nJylai9WbT2YCDBmatFN7wqZEbYoc9oF2fI5bCH8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748876349; c=relaxed/simple; bh=U76p8J/dP1FRLW1OHfizZCnhk6f8RLVJiirARJ5Ua3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hsLW2ElVxcoJk4ZUGa47sVM2+xOMJ473GGBZeIPzK9gRiJUAQaKyEgeS2YSOBpspwDPs5u94WAU5QAMMzVCkHwwVPxLObdbgEk6WrcQQhHYoaIXm4rDdd4A7nbMVnLuOA2WLnWJoZQ4L+nCWCHGhVd5uwlrqCvipeFbG+HaV1Ew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: gaUjNlcFQ8u550OaGhL61Q== X-CSE-MsgGUID: m3UexrM0S2GT/Ri+ML6VUw== X-IronPort-AV: E=McAfee;i="6700,10204,11451"; a="38512399" X-IronPort-AV: E=Sophos;i="6.16,203,1744095600"; d="scan'208";a="38512399" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2025 07:59:07 -0700 X-CSE-ConnectionGUID: 8Dyvj7vwSx+NQ2Hya0Mppw== X-CSE-MsgGUID: hr82fmzXR2uwYsMY4XUFiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,203,1744095600"; d="scan'208";a="149563320" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2025 07:59:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uM6ct-00000002sDm-0isY; Mon, 02 Jun 2025 17:58:59 +0300 Date: Mon, 2 Jun 2025 17:58:58 +0300 From: Andy Shevchenko To: Pop Ioan Daniel Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sergiu Cuciurean , Dragos Bogdan , Antoniu Miclaus , Olivier Moysan , Javier Carrasco , Matti Vaittinen , Tobias Sperling , Alisa-Dariana Roman , Marcelo Schmitt , Herve Codina , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set Message-ID: References: <20250602134349.1930891-1-pop.ioan-daniel@analog.com> <20250602134349.1930891-3-pop.ioan-daniel@analog.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250602134349.1930891-3-pop.ioan-daniel@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Jun 02, 2025 at 04:43:40PM +0300, Pop Ioan Daniel wrote: > Add chan parameter to iio_backend_oversampling_ratio_set() to allow > for contexts where the channel must be specified. Modify all > existing users. ... > static int ad4851_set_oversampling_ratio(struct iio_dev *indio_dev, > if (ret) > return ret; > } > - Why do you remove this blank line? To me these two blocks do not look toughly coupled. > - ret = iio_backend_oversampling_ratio_set(st->back, osr); > + /* Channel is ignored by the backend being used here */ > + ret = iio_backend_oversampling_ratio_set(st->back, 0, osr); > if (ret) > return ret; -- With Best Regards, Andy Shevchenko