From: Raag Jadav <raag.jadav@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org, Badal Nilawar <badal.nilawar@intel.com>
Subject: Re: [PATCH v2] drm/xe/hwmon: Simplify and fix 32b wrap
Date: Mon, 2 Jun 2025 19:16:16 +0300 [thread overview]
Message-ID: <aD3OUGCdihky6qyo@black.fi.intel.com> (raw)
In-Reply-To: <20250530-xe-hwmon-wrap-v2-1-ce653db7fe4a@intel.com>
On Fri, May 30, 2025 at 03:31:57PM -0700, Lucas De Marchi wrote:
> Like done in commit eaa287069a70 ("drm/xe/guc_submit: Simplify and fix
> diff calculation"), just use u32 for wrapping the value, which is
> simpler and more correct: when wrapping on 32b, the accumulated value
> was off by one.
>
> Also, do not mix the u64 value from pmt with the u32 value used for the
> calculation.
>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Raag Jadav <raag.jadav@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> Changes in v2:
> - Rebase - now there's a u64 coming from pmt that was mixed as
> "reg_val", so use separate variables.
> - Removed previous r-b due to the code changes. Raag, please let me know
> if you are still ok with this
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
prev parent reply other threads:[~2025-06-02 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 22:31 [PATCH v2] drm/xe/hwmon: Simplify and fix 32b wrap Lucas De Marchi
2025-05-30 22:37 ` ✓ CI.Patch_applied: success for drm/xe/hwmon: Simplify and fix 32b wrap (rev2) Patchwork
2025-05-30 22:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-30 22:39 ` ✓ CI.KUnit: success " Patchwork
2025-05-30 22:49 ` ✓ CI.Build: " Patchwork
2025-05-30 22:52 ` ✓ CI.Hooks: " Patchwork
2025-05-30 22:53 ` ✓ CI.checksparse: " Patchwork
2025-05-30 23:17 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-01 19:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-06-02 16:16 ` Raag Jadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD3OUGCdihky6qyo@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.