From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] tests/functional: Use the 'none' machine for the VNC test
Date: Tue, 3 Jun 2025 11:41:06 +0100 [thread overview]
Message-ID: <aD7RQv5Cok4BxvbR@redhat.com> (raw)
In-Reply-To: <20250603103449.32499-1-thuth@redhat.com>
On Tue, Jun 03, 2025 at 12:34:49PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> The VNC test currently fails if the default machine ("pc" for x86)
> has not been compiled into the binary. Since we also can test VNC
> when QEMU just shows the default monitor, let's avoid this problem
> by simply using the "none" machine (which is always available)
> here instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/test_vnc.py | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-06-03 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 10:34 [PATCH] tests/functional: Use the 'none' machine for the VNC test Thomas Huth
2025-06-03 10:41 ` Daniel P. Berrangé [this message]
2025-06-03 11:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aD7RQv5Cok4BxvbR@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.