All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Seyi Kuforiji <kuforiji98@gmail.com>
Cc: git@vger.kernel.org, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework
Date: Tue, 3 Jun 2025 16:14:01 +0200	[thread overview]
Message-ID: <aD8DKUrPEi0robtt@pks.im> (raw)
In-Reply-To: <CAGedMtcaV5r-hVn_aPP=AVCV-Wx0uX-yPqcOijxJh+qTSDJXrA@mail.gmail.com>

On Tue, Jun 03, 2025 at 03:03:45PM +0100, Seyi Kuforiji wrote:
> On Tue, 3 Jun 2025 at 14:51, Patrick Steinhardt <ps@pks.im> wrote:
> > On Mon, Jun 02, 2025 at 01:25:50PM +0100, Seyi Kuforiji wrote:
> > >  Makefile                         |   2 +-
> > >  t/meson.build                    |   2 +-
> > >  t/unit-tests/t-reftable-basics.c | 219 -----------------------------
> > >  t/unit-tests/u-reftable-basics.c | 227 +++++++++++++++++++++++++++++++
> > >  4 files changed, 229 insertions(+), 221 deletions(-)
> > >  delete mode 100644 t/unit-tests/t-reftable-basics.c
> > >  create mode 100644 t/unit-tests/u-reftable-basics.c
> >
> > Hm, these still show as deletion and addition :/ Did you try playing
> > around with the creation factor? What is the exact command that you have
> > used to generate these mails?
> >
> > Patrick
> 
> This was the only file that came out as a deletion and creation. Below
> is the command I used:
> 
> `git format-patch -v3 --cover-letter --find-renames=20%
> --range-diff=upstream/master..convert-reftable-clar-v2
> upstream/master`

Ah, true indeed. Never mind then, I think this is good enough :) Thanks!

Patrick

  reply	other threads:[~2025-06-03 14:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 12:25 [PATCH v3 00/10] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 01/10] t/unit-tests: implement clar specific reftable test helper functions Seyi Kuforiji
2025-06-02 13:23   ` Kristoffer Haugsbakk
2025-06-02 12:25 ` [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework Seyi Kuforiji
2025-06-03 13:51   ` Patrick Steinhardt
2025-06-03 14:03     ` Seyi Kuforiji
2025-06-03 14:14       ` Patrick Steinhardt [this message]
2025-06-02 12:25 ` [PATCH v3 03/10] t/unit-tests: convert reftable block test to use clar Seyi Kuforiji
2025-06-03 14:18   ` Patrick Steinhardt
2025-06-02 12:25 ` [PATCH v3 04/10] t/unit-tests: convert reftable merged " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 05/10] t/unit-tests: convert reftable pq " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 06/10] t/unit-tests: convert reftable table " Seyi Kuforiji
2025-06-02 19:33   ` Junio C Hamano
2025-06-03 11:46     ` Seyi Kuforiji
2025-06-03 19:12     ` Junio C Hamano
2025-06-02 12:25 ` [PATCH v3 07/10] t/unit-tests: convert reftable readwrite " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 08/10] t/unit-tests: convert reftable record " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 09/10] t/unit-tests: convert reftable stack " Seyi Kuforiji
2025-06-02 12:25 ` [PATCH v3 10/10] t/unit-tests: finalize migration of reftable-related tests Seyi Kuforiji
2025-06-03 13:51   ` Patrick Steinhardt
2025-06-05 12:56     ` Seyi Kuforiji
2025-06-05 13:24       ` Patrick Steinhardt
2025-06-05 16:56         ` Junio C Hamano
2025-06-03 18:41 ` [PATCH v3 00/10] t/unit-tests: convert unit-tests to use clar Junio C Hamano
2025-06-04 10:09   ` Seyi Kuforiji
2025-06-04 10:09   ` Seyi Kuforiji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aD8DKUrPEi0robtt@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=kuforiji98@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.