From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] [RFC] xfs: fix unmount hang with unflushable inodes stuck in the AIL
Date: Thu, 22 May 2025 22:07:13 -0700 [thread overview]
Message-ID: <aDACgQ8j42TFeRA-@infradead.org> (raw)
In-Reply-To: <20250515025628.3425734-3-david@fromorbit.com>
First a note: I gave up on my previous rushed attempt to review this
because the patch was just too big for my limited mental capacity.
Today I instead split out the relatively trivial prep parts to focus
on the changes. I've pushed my split to:
git://git.infradead.org/users/hch/xfsprogs.git shutdown-deadlock-split
it would be great to pick that up or do something similar for the next
round. After your patch I've also added two cosmetic patches.
With that the change does look good to me, and the bli reference
count scheme looks almost sane to me. Although it makes me wonder
if we should just keep a BLI reference for any BLI in the AIL to
further simplify it eventually?
next prev parent reply other threads:[~2025-05-23 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 2:42 [PATCH 0/2] xfs: unmount hang fixes Dave Chinner
2025-05-15 2:42 ` [PATCH 1/2] xfs: xfs_ifree_cluster vs xfs_iflush_shutdown_abort deadlock Dave Chinner
2025-05-23 4:35 ` Christoph Hellwig
2025-05-15 2:42 ` [PATCH 2/2] [RFC] xfs: fix unmount hang with unflushable inodes stuck in the AIL Dave Chinner
2025-05-23 5:07 ` Christoph Hellwig [this message]
2025-05-23 5:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDACgQ8j42TFeRA-@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.