Re: [PATCH v3] iio: cros_ec_sensors: add cros_ec_activity driver

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Thu, May 22, 2025 at 08:18:49PM -0700, Gwendal Grignou wrote:
> ChromeOS EC can report activity information derived from the
> accelerometer:
> - Reports on-body/off-body as a proximity event.
> - Reports significant motion as an activity event.
> 
> This new sensor is a virtual sensor, included only when the EC firmware
> is compiled with the appropriate module.
> 
> Signed-off-by: Gwendal Grignou <gwendal@google.com>

Looks neat to me.  With removing a nit,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c b/drivers/iio/common/cros_ec_sensors/cros_ec_activity.c
> [...]
> +static int cros_ec_write_event_config(struct iio_dev *indio_dev,
> [...]
> +	st->core.param.set_activity.enable = state;
> +	if (ret == 0)
> +		ret = cros_ec_motion_send_host_cmd(&st->core, 0);

The assignment of `set_activity.enable` should be in the if-branch too.