All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: rujra <braker.noob.kernel@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	elder@kernel.org, Greg KH <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy()
Date: Fri, 23 May 2025 11:19:42 +0300	[thread overview]
Message-ID: <aDAvnmtgnssj7K5l@stanley.mountain> (raw)
In-Reply-To: <CAG+54DZgF55R2pEtkVBdnwXEyNu9TrSMA9zkmw7RjWrDqX4SsQ@mail.gmail.com>

On Sat, May 17, 2025 at 09:11:30AM +0530, rujra wrote:
> To ensuring that the firmware_tag is properly null-terminated. When
> copying firmware tag strings to prevent buffer overflows and ensure
> data integrity.
> 
> The maximum size of tag is GB_FIRMWARE_U_TAG_MAX_SIZE = 10 bytes, and it
> may or may not be NULL-terminated.
> included in "greybus_firmware.h"
> 
> changes has been made at 3 positions:
> 1: update firmware tag
> 2: backend update firmware tag
> 3: backend update firmware tag with unipro
> 
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>

From doesn't match Signed-off-by line.

The patch is corrupted and doesn't apply.  Read the two paragraphs of
Documentation/process/email-clients.rst.

This is a usespace program so I don't think it has a strscpy()
function.  How did you compile this?

regards,
dan carpenter


  reply	other threads:[~2025-05-23  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17  3:41 [PATCH] staging : greybus : Documentation : firmware : Replace deprecated strncpy() with strscpy() rujra
2025-05-23  8:19 ` Dan Carpenter [this message]
2025-06-01  9:31   ` Rujra Bhatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDAvnmtgnssj7K5l@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=braker.noob.kernel@gmail.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.