From: Alice Ryhl <aliceryhl@google.com>
To: Benno Lossin <lossin@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Fiona Behrens" <me@kloenk.dev>,
"Benno Lossin" <benno.lossin@proton.me>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rust: pin-init: examples: pthread_mutex: disable the main test for miri
Date: Fri, 23 May 2025 18:26:19 +0000 [thread overview]
Message-ID: <aDC9y829vZZBzZ2p@google.com> (raw)
In-Reply-To: <20250523125424.192843-3-lossin@kernel.org>
On Fri, May 23, 2025 at 02:54:12PM +0200, Benno Lossin wrote:
> From: Benno Lossin <benno.lossin@proton.me>
>
> `miri` takes a long time to execute the test, so disable it.
>
> Link: https://github.com/Rust-for-Linux/pin-init/pull/50/commits/e717a9eec85024c11e79e8bd9dcb664ad0de8f94
> Signed-off-by: Benno Lossin <lossin@kernel.org>
I usually recommend ignoring tests rather than cfg'ing them out
entirely.
#[cfg_attr(miri, ignore)]
next prev parent reply other threads:[~2025-05-23 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 12:54 [PATCH 0/3] pin-init sync: test & CI fixes Benno Lossin
2025-05-23 12:54 ` [PATCH 1/3] rust: pin-init: examples, tests: add conditional compilation in order to compile under any feature combination Benno Lossin
2025-05-23 12:54 ` [PATCH 2/3] rust: pin-init: examples: pthread_mutex: disable the main test for miri Benno Lossin
2025-05-23 18:26 ` Alice Ryhl [this message]
2025-05-26 8:20 ` Benno Lossin
2025-05-23 12:54 ` [PATCH 3/3] rust: pin-init: feature-gate the `stack_init_reuse` test on the `std` feature Benno Lossin
2025-06-09 19:52 ` [PATCH 0/3] pin-init sync: test & CI fixes Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDC9y829vZZBzZ2p@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.