Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives

[Niklas Cassel <cassel@kernel.org>]

Mikko,

On Fri, May 23, 2025 at 04:27:23PM +0300, Mikko Juhani Korhonen wrote:
> > I would add some debug prints around:
> >
> > https://github.com/torvalds/linux/blob/v6.15-rc6/drivers/ata/libata-eh.c#L3512-L3520
> >
> > To
> > 1) Make sure that we actually send down the SET FEATURES command for
> > to the drive.
> >
> > 2) Check the return code (err_mask). This code looks a bit sketchy,
> > if (err_mask && err_mask != AC_ERR_DEV) {
> >
> > It seems that if err_mask == AC_ERR_DEV, the error would get silently
> > discarded...
> 
> 
> Hello Niklas,
> I did add debug print here and checked that at least there is no silently
> ignored errors here, err_mask is zero even for my problem case
> sata ports 5,6 -> WDC WD20EFAX-68FB5N0
> and also for some others I tested.

Thanks a lot for testing!


Kind regards,
Niklas