From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Elena Reshetova <elena.reshetova@intel.com>,
seanjc@google.com, kai.huang@intel.com, mingo@kernel.org,
linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, asit.k.mallick@intel.com,
vincent.r.scarlata@intel.com, chongc@google.com,
erdemaktas@google.com, vannapurve@google.com,
dionnaglaze@google.com, bondarn@google.com,
scott.raynor@intel.com
Subject: Re: [PATCH v6 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open()
Date: Sat, 24 May 2025 02:45:35 +0300 [thread overview]
Message-ID: <aDEIn4Ra6HMEVy9R@kernel.org> (raw)
In-Reply-To: <d7ae8e13-2b44-4466-b345-fb06b40a24d3@intel.com>
On Fri, May 23, 2025 at 08:58:54AM -0700, Dave Hansen wrote:
> On 5/23/25 08:54, Jarkko Sakkinen wrote:
> >> +void sgx_dec_usage_count(void)
> >> +{
> >> + atomic64_dec(&sgx_usage_count);
> >> +}
> > I think these both should be static inlines in arch/x86/kernel/cpu/sgx.h.
> > Global symbols is over the top. Even if I think disassembly (when doing
> > debugging, bug hunting or similar tasks), it'd nicer that way.
>
> If they're just used in a single file, make them 'static' and let the
> compiler decide whether to inline them or not.
This would be totally fine.
BR, Jarkko
next prev parent reply other threads:[~2025-05-23 23:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 9:21 [PATCH v6 0/5] Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-05-22 9:21 ` [PATCH v6 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open() Elena Reshetova
2025-05-23 15:54 ` Jarkko Sakkinen
2025-05-23 15:58 ` Dave Hansen
2025-05-23 23:45 ` Jarkko Sakkinen [this message]
2025-05-26 11:48 ` Reshetova, Elena
2025-05-26 11:45 ` Reshetova, Elena
2025-05-26 23:19 ` Huang, Kai
2025-05-27 8:02 ` Reshetova, Elena
2025-05-22 9:21 ` [PATCH v6 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag Elena Reshetova
2025-05-23 0:18 ` Huang, Kai
2025-05-23 6:35 ` Reshetova, Elena
2025-05-22 9:21 ` [PATCH v6 3/5] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN] Elena Reshetova
2025-05-23 15:56 ` Jarkko Sakkinen
2025-05-22 9:21 ` [PATCH v6 4/5] x86/sgx: Implement ENCLS[EUPDATESVN] Elena Reshetova
2025-05-23 0:08 ` Huang, Kai
2025-05-29 13:41 ` Reshetova, Elena
2025-05-23 15:57 ` Jarkko Sakkinen
2025-05-23 15:59 ` Jarkko Sakkinen
2025-05-26 11:09 ` Reshetova, Elena
2025-05-22 9:21 ` [PATCH v6 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves Elena Reshetova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDEIn4Ra6HMEVy9R@kernel.org \
--to=jarkko@kernel.org \
--cc=asit.k.mallick@intel.com \
--cc=bondarn@google.com \
--cc=chongc@google.com \
--cc=dave.hansen@intel.com \
--cc=dionnaglaze@google.com \
--cc=elena.reshetova@intel.com \
--cc=erdemaktas@google.com \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=scott.raynor@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=vincent.r.scarlata@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.