From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] rtc: rzn1: support input frequencies other than 32768Hz
Date: Mon, 26 May 2025 09:38:06 +0200 [thread overview]
Message-ID: <aDQaXv2MR0Tvc4AP@shikoro> (raw)
In-Reply-To: <87frgr4z0o.fsf@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
> > + rzn1_rtc_ops.read_offset = rzn1_rtc_read_offset;
> > + rzn1_rtc_ops.set_offset = rzn1_rtc_set_offset;
>
> I guess this situation is not possible but let me ask. Do we care
> about the very unlikely case where two RTCs are available and configured
> differently? Because we are overwriting a static entry here. Maybe we
> could have two static structures and pick the correct one during probe
> instead.
True, it is so highly unlikely that I didn't think of it. But
theoretically possible, I'll fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-05-26 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 15:05 [PATCH v2 0/3] rtc: rzn1: support XTAL clk and SCMP method Wolfram Sang
2025-05-23 15:05 ` [PATCH v2 1/3] dt-bindings: rtc: rzn1: add optional second clock Wolfram Sang
2025-05-23 15:05 ` [PATCH v2 2/3] rtc: rzn1: Disable controller before initialization Wolfram Sang
2025-05-23 15:05 ` [PATCH v2 3/3] rtc: rzn1: support input frequencies other than 32768Hz Wolfram Sang
2025-05-26 7:22 ` Miquel Raynal
2025-05-26 7:38 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDQaXv2MR0Tvc4AP@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=alexandre.belloni@bootlin.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.