All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, rafael@kernel.org, viresh.kumar@linaro.org,
	mathieu.desnoyers@efficios.com, paulmck@kernel.org,
	hannes@cmpxchg.org, surenb@google.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	tj@kernel.org
Subject: Re: [PATCH] sched: Make clangd usable
Date: Mon, 26 May 2025 10:11:52 +0200	[thread overview]
Message-ID: <aDQiSF0OwoSBMkE3@gmail.com> (raw)
In-Reply-To: <20250523164348.GN39944@noisy.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> Due to the weird Makefile setup of sched the various files do not 
> compile as stand alone units. The new generation of editors are 
> trying to do just this -- mostly to offer fancy things like 
> completions but also better syntax highlighting and code navigation.
> 
> Specifically, I've been playing around with neovim and clangd.
> 
> Setting up clangd on the kernel source is a giant pain in the arse 
> (this really should be improved), but once you do manage, you run 
> into dumb stuff like the above.
> 
> Fix up the scheduler files to at least pretend to work.

>  kernel/sched/autogroup.c         |    3 +++
>  kernel/sched/autogroup.h         |    2 ++
>  kernel/sched/clock.c             |    3 +++
>  kernel/sched/completion.c        |    5 +++++
>  kernel/sched/core_sched.c        |    2 ++
>  kernel/sched/cpuacct.c           |    2 ++
>  kernel/sched/cpudeadline.c       |    1 +
>  kernel/sched/cpudeadline.h       |    2 ++
>  kernel/sched/cpufreq.c           |    1 +
>  kernel/sched/cpufreq_schedutil.c |    2 ++
>  kernel/sched/cpupri.c            |    1 +
>  kernel/sched/cpupri.h            |    3 +++
>  kernel/sched/cputime.c           |    3 +++
>  kernel/sched/deadline.c          |    4 ++++
>  kernel/sched/debug.c             |    3 +++
>  kernel/sched/idle.c              |    5 +++++
>  kernel/sched/isolation.c         |    2 ++
>  kernel/sched/loadavg.c           |    2 ++
>  kernel/sched/membarrier.c        |    2 ++
>  kernel/sched/pelt.c              |    1 +
>  kernel/sched/pelt.h              |    7 ++++++-
>  kernel/sched/psi.c               |    2 ++
>  kernel/sched/rt.c                |    3 +++
>  kernel/sched/sched-pelt.h        |    1 +
>  kernel/sched/sched.h             |    1 +
>  kernel/sched/smp.h               |    1 +
>  kernel/sched/stats.c             |    1 +
>  kernel/sched/stop_task.c         |    1 +
>  kernel/sched/swait.c             |    1 +
>  kernel/sched/topology.c          |    2 ++
>  kernel/sched/wait.c              |    1 +
>  kernel/sched/wait_bit.c          |    3 +++
>  32 files changed, 72 insertions(+), 1 deletion(-)

Yeah, I see no reason why this wouldn't work - and the original build 
speedup will still be present.

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  parent reply	other threads:[~2025-05-26  8:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 16:43 [PATCH] sched: Make clangd usable Peter Zijlstra
2025-05-23 16:48 ` Tejun Heo
2025-05-23 18:19   ` Tejun Heo
2025-05-23 21:02   ` Andrea Righi
2025-05-23 16:49 ` Peter Zijlstra
2025-05-23 18:09   ` Steven Rostedt
2025-05-26  7:41     ` Peter Zijlstra
2025-05-26  8:11 ` Ingo Molnar [this message]
2025-05-26  8:59 ` Peter Zijlstra
2025-05-26  9:04   ` Peter Zijlstra
2025-05-26 11:44   ` Peter Zijlstra
2025-05-26 14:49 ` Juri Lelli
2025-06-11  9:29 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDQiSF0OwoSBMkE3@gmail.com \
    --to=mingo@kernel.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.