All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 0/3] netfilter: nf_set_pipapo_avx2: fix initial map fill
Date: Mon, 26 May 2025 16:14:25 +0200	[thread overview]
Message-ID: <aDR3QTIqNJC3E546@strlen.de> (raw)
In-Reply-To: <20250526141439.28a25297@elisabeth>

Stefano Brivio <sbrivio@redhat.com> wrote:
> > Because the selftest data path test does:
> >    .... @test counter name ...
> > 
> > .. and then checks if the counter has been incremented, the selftest
> > first needs to be reworked to use per-element counters.
> 
> That makes sense indeed, I didn't even know they existed. Actually, I
> just learnt about 'nft reset element', that's quite neat.

Pipapo predates the per element counters so no wonder you did
not use them in the original selftest :-)

Thanks for reviewing!

      reply	other threads:[~2025-05-26 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 12:20 [PATCH nf-next 0/3] netfilter: nf_set_pipapo_avx2: fix initial map fill Florian Westphal
2025-05-23 12:20 ` [PATCH nf-next 1/3] " Florian Westphal
2025-05-30  6:15   ` Pablo Neira Ayuso
2025-05-30 10:26     ` Florian Westphal
2025-05-23 12:20 ` [PATCH nf-next 2/3] selftests: netfilter: nft_concat_range.sh: prefer per element counters for testing Florian Westphal
2025-05-23 12:20 ` [PATCH nf-next 3/3] selftests: netfilter: nft_concat_range.sh: add datapath check for map fill bug Florian Westphal
2025-05-26 12:14 ` [PATCH nf-next 0/3] netfilter: nf_set_pipapo_avx2: fix initial map fill Stefano Brivio
2025-05-26 14:14   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDR3QTIqNJC3E546@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.