From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11AD6202C21 for ; Mon, 26 May 2025 12:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748262729; cv=none; b=Zgb4oUtxhGkSOL6siv4jEPkGrBFoLod6JQDhNXLGQ9TYgNklBUGeErPkUT9ITdcm9UkhQGhiR74ORXgAau37bvEWu06JXGLIU+cBnimBbyk3eXQcWYv2yBBCGTiHSpUG/hFX5tKzzgYTGFX7fIoZ9kGpRv5mnHUX/1xwirONS14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748262729; c=relaxed/simple; bh=FBsYQ8+ww/WokZHkiHNznAD6eoyUNX3RscIn/DkHjVo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E1ar8gYBM55e+M/pPyh9KXhKpzsOo2D6K1sCoPJE7ZTAfqMv1kWYFSsWin3rLVn6HYJas1wg4EOCQZYCBrQ6JkijBRbmBz4tFEUmiVJIEZpx8sPOFj1NucdHfZonFV/cP1j1zMozgJRQO+o4EkUVsNUutcgNL9TVjABhgk78tyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id EFD4B602B1; Mon, 26 May 2025 14:32:03 +0200 (CEST) Date: Mon, 26 May 2025 16:14:25 +0200 From: Florian Westphal To: Stefano Brivio Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next 0/3] netfilter: nf_set_pipapo_avx2: fix initial map fill Message-ID: References: <20250523122051.20315-1-fw@strlen.de> <20250526141439.28a25297@elisabeth> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250526141439.28a25297@elisabeth> Stefano Brivio wrote: > > Because the selftest data path test does: > > .... @test counter name ... > > > > .. and then checks if the counter has been incremented, the selftest > > first needs to be reworked to use per-element counters. > > That makes sense indeed, I didn't even know they existed. Actually, I > just learnt about 'nft reset element', that's quite neat. Pipapo predates the per element counters so no wonder you did not use them in the original selftest :-) Thanks for reviewing!