From: Andy Shevchenko <andy@kernel.org>
To: maudspierings@gocontroll.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Christian Heusel" <christian@heusel.eu>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v4] iio: common: st_sensors: Fix use of uninitialize device structs
Date: Tue, 27 May 2025 11:18:00 +0300 [thread overview]
Message-ID: <aDV1OF6EKqLMl2D8@smile.fi.intel.com> (raw)
In-Reply-To: <20250527-st_iio_fix-v4-1-12d89801c761@gocontroll.com>
On Tue, May 27, 2025 at 08:36:08AM +0200, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
>
> Throughout the various probe functions &indio_dev->dev is used before it
> is initialized. This caused a kernel panic in st_sensors_power_enable()
> when the call to devm_regulator_bulk_get_enable() fails and then calls
> dev_err_probe() with the uninitialized device.
>
> This seems to only cause a panic with dev_err_probe(), dev_err(),
> dev_warn() and dev_info() don't seem to cause a panic, but are fixed
> as well.
>
> The issue is reported and traced here: [1]
FWIW,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-27 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 6:36 [PATCH v4] iio: common: st_sensors: Fix use of uninitialize device structs Maud Spierings
2025-05-27 6:36 ` Maud Spierings via B4 Relay
2025-05-27 8:18 ` Andy Shevchenko [this message]
2025-05-31 17:03 ` Jonathan Cameron
2025-06-23 13:27 ` Maud Spierings
2025-06-28 17:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDV1OF6EKqLMl2D8@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=christian@heusel.eu \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maudspierings@gocontroll.com \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.