From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Manuel Bouyer <bouyer@antioche.eu.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86/pv: Fix breakpoint reporting
Date: Tue, 27 May 2025 12:59:23 +0200 [thread overview]
Message-ID: <aDWbCzpdBxMwGIkX@macbook.local> (raw)
In-Reply-To: <20250526205302.997387-1-andrew.cooper3@citrix.com>
On Mon, May 26, 2025 at 09:53:02PM +0100, Andrew Cooper wrote:
> x86_merge_dr6() is not a no-op when 0 is passed in; it will discard the
> previously latched breakpoint bits.
>
> The combination of do_debug()'s manual call to x86_merge_dr6() for external
> debuggers, and pv_inject_DB() calling pv_inject_event(), results in two
> x86_merge_dr6() calls.
>
> Feed the same pending_dbg in the second time. This makes pv_inject_event()'s
> update of dr6 effectively a no-op, retaining the correct breakpoint bits.
>
> Fixes: db39fa4b27ea ("x86/pv: Fix merging of new status bits into %dr6")
> Reported-by: Manuel Bouyer <bouyer@antioche.eu.org>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
prev parent reply other threads:[~2025-05-27 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 17:59 Xen 4.18.5 PV dbregs fail Manuel Bouyer
2025-05-26 18:06 ` Andrew Cooper
2025-05-26 18:17 ` Andrew Cooper
2025-05-26 18:46 ` Manuel Bouyer
2025-05-26 18:50 ` Andrew Cooper
2025-05-26 20:13 ` Manuel Bouyer
2025-05-26 20:30 ` Andrew Cooper
2025-05-26 20:56 ` Manuel Bouyer
2025-05-26 21:10 ` Manuel Bouyer
2025-05-26 21:17 ` Andrew Cooper
2025-05-26 21:30 ` Manuel Bouyer
2025-05-26 18:41 ` Manuel Bouyer
2025-05-26 20:53 ` [PATCH] x86/pv: Fix breakpoint reporting Andrew Cooper
2025-05-27 10:59 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDWbCzpdBxMwGIkX@macbook.local \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bouyer@antioche.eu.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.