From: Alexey Gladkov <legion@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Petr Pavlu <petr.pavlu@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kbuild@vger.kernel.org, Khalid Aziz <khalid@gonehiking.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary
Date: Tue, 27 May 2025 13:54:49 +0200 [thread overview]
Message-ID: <aDWoCU2YrxaCBi42@example.org> (raw)
In-Reply-To: <f361faffc1863358e8fda98f994f6a49b6f0d4c9.camel@HansenPartnership.com>
On Tue, May 27, 2025 at 07:28:59AM -0400, James Bottomley wrote:
> On Tue, 2025-05-27 at 11:07 +0200, Alexey Gladkov wrote:
> > Define MODULE_DEVICE_TABLE only if a structure is defined for it.
> >
> > drivers/scsi/BusLogic.c:3735:26: error: use of undeclared identifier
> > 'blogic_pci_tbl'
> > 3735 | MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);
>
> Well, a) need to cc the scsi list
Sorry. I miss it.
> and b) how is this possible when
> MODULE_DEVICE_TABLE() has an empty definition if MODULE isn't defined
> (so the guard you move should be over an empty statement)?
In the next patch:
[PATCH v3 4/6] modpost: Create modalias for builtin modules
I remove this condition for the MODULE_DEVICE_TABLE macro and it will be
always defined.
I put the drivers/scsi/BusLogic.c change before these changes to avoid
errors. Besides, even an empty macro uses a structure name that is not
defined (if MODULE isn't defined). This seems wrong in any case.
--
Rgrds, legion
next prev parent reply other threads:[~2025-05-27 11:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 9:07 [PATCH v3 0/6] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary Alexey Gladkov
2025-05-27 11:28 ` James Bottomley
2025-05-27 11:54 ` Alexey Gladkov [this message]
2025-05-27 11:58 ` James Bottomley
2025-05-27 12:58 ` Alexey Gladkov
2025-05-27 14:06 ` [PATCH v4 1/6] scsi: Always define blogic_pci_tbl structure Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 2/6] modules: Add macros to specify modinfo prefix Alexey Gladkov
2025-06-02 7:49 ` Masahiro Yamada
2025-06-09 9:37 ` Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique Alexey Gladkov
2025-06-02 7:45 ` Masahiro Yamada
2025-06-02 8:06 ` Alexey Gladkov
2025-06-02 10:58 ` Masahiro Yamada
2025-06-02 14:03 ` Alexey Gladkov
2025-06-02 16:18 ` Masahiro Yamada
2025-06-02 17:09 ` Alexey Gladkov
2025-06-04 11:26 ` Alexey Gladkov
2025-06-06 5:10 ` Masahiro Yamada
2025-06-06 11:20 ` Masahiro Yamada
2025-06-02 7:52 ` Masahiro Yamada
2025-06-02 8:24 ` Alexey Gladkov
2025-06-02 18:00 ` Masahiro Yamada
2025-06-02 18:44 ` Alexey Gladkov
2025-06-06 5:12 ` Masahiro Yamada
2025-05-27 9:07 ` [PATCH v3 4/6] modpost: Create modalias for builtin modules Alexey Gladkov
2025-05-27 9:07 ` [PATCH v3 5/6] kbuild: Move modules.builtin.modinfo to another makefile Alexey Gladkov
2025-05-28 13:21 ` kernel test robot
2025-05-28 15:20 ` Alexey Gladkov
2025-05-27 9:08 ` [PATCH v3 6/6] kbuild: Create modules.builtin.modinfo for modpost results Alexey Gladkov
2025-05-27 13:15 ` [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE Alexey Gladkov
2025-05-27 13:22 ` James Bottomley
2025-05-27 13:44 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDWoCU2YrxaCBi42@example.org \
--to=legion@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=da.gomez@samsung.com \
--cc=khalid@gonehiking.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.