Re: [bug report] ASoC: SDCA: Create DAPM widgets and routes from DisCo

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, May 27, 2025 at 01:04:26PM +0300, Dan Carpenter wrote:
> sound/soc/sdca/sdca_asoc.c
>     377 static int entity_pde_event(struct snd_soc_dapm_widget *widget,
>     378                             struct snd_kcontrol *kctl, int event)
>     379 {
>     380         struct snd_soc_component *component = widget->dapm->component;
>     381         struct sdca_entity *entity = widget->priv;
>     382         static const int polls = 100;
>     383         unsigned int reg, val;
>     384         int from, to, i;
>     385         int poll_us;
>     386         int ret;
>     387 
>     388         if (!component)
>     389                 return -EIO;
>     390 
>     391         switch (event) {
>     392         case SND_SOC_DAPM_POST_PMD:
>     393                 from = widget->on_val;
>     394                 to = widget->off_val;
>     395                 break;
>     396         case SND_SOC_DAPM_POST_PMU:
>     397                 from = widget->off_val;
>     398                 to = widget->on_val;
>     399                 break;
> 
> Smatch does a fairly naive analysis of the callers and thinks that
> event could be 1-2,4,8,16,32,64,128.

This should actually be safe as the widget that uses this
callback only registers for these two events, that said it is
probably nicer to have a default case anyway incase things change
later. I will fire out a patch shortly.

Thanks,
Charles