Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile memory device

From: Raag Jadav <raag.jadav@intel.com>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Poosa, Karthik" <karthik.poosa@intel.com>,
	"Abliyev, Reuven" <reuven.abliyev@intel.com>,
	"Weil, Oren jer" <oren.jer.weil@intel.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile memory device
Date: Tue, 27 May 2025 21:37:07 +0300	[thread overview]
Message-ID: <aDYGUzSWLdeyzpQ_@black.fi.intel.com> (raw)
In-Reply-To: <CY5PR11MB63666722F7C02E4D776CE601ED64A@CY5PR11MB6366.namprd11.prod.outlook.com>

On Tue, May 27, 2025 at 11:55:13AM +0530, Usyskin, Alexander wrote:
> > Subject: Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile
> > memory device
> > 
> > On Thu, May 15, 2025 at 04:33:43PM +0300, Alexander Usyskin wrote:
> > > Enable access to internal non-volatile memory on DGFX
> > > with GSC/CSC devices via a child device.
> > > The nvm child device is exposed via auxiliary bus.
> > 
> > ...
> > 
> > > +void xe_nvm_init(struct xe_device *xe)
> > > +{
> > 
> > Same as patch 6, please handle errors.
> This device failure is non-fatal for Xe, caller will ignore
> the failure anyway.

Same as patch 6, let's atleast have the readiness.

Raag