Re: [PATCH 2/7 nft] tunnel: add erspan support

[Florian Westphal <fw@strlen.de>]

Fernando Fernandez Mancera <fmancera@suse.de> wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> This patch extends the tunnel metadata object to define erspan tunnel
> specific configurations:
> 
>  table netdev x {
>         tunnel y {
>                 id 10
>                 ip saddr 192.168.2.10
>                 ip daddr 192.168.2.11
>                 sport 10
>                 dport 20
>                 ttl 10
>                 erspan {
>                         version 1
>                         index 2
>                 }
>         }
>  }

Would it make sense to make this

tunnel erspan y {
                 id 10
                 ip saddr 192.168.2.10
                 ip daddr 192.168.2.11
                 sport 10
                 dport 20
                 ttl 10
                 version 1
                 index 2
}

Or was the sub-section intentional to cleanly separate the common parts
from the tunnel specific knobs?

In that case, maybe 'tunnel y {
	...
	type erspan { ... '?

Or do you think its unecessarily verbose?

I think it might be good to make it clear that this is an either-or thing
and multiple 'type' declarations aren't permitted.

Or are there plans to support

table netdev x {
       tunnel y {
               id 10
               ip saddr 192.168.2.10
               ip daddr 192.168.2.11
               sport 10
               dport 20
               ttl 10
               erspan {
                       version 1
                       index 2
	       }
	       geneve {
		...
?