From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
device-mapper development <dm-devel@lists.linux.dev>
Subject: Re: [PATCH] multipathd: always reset checker interval for failed paths
Date: Tue, 27 May 2025 22:01:14 -0400 [thread overview]
Message-ID: <aDZuageAzJxJHCeC@redhat.com> (raw)
In-Reply-To: <4b4107e368e68588dd21d3d386b7f84babc5ed1f.camel@suse.com>
On Fri, May 23, 2025 at 01:04:15PM +0200, Martin Wilck wrote:
> On Fri, 2025-05-23 at 13:00 +0200, Martin Wilck wrote:
> > On Wed, 2025-05-21 at 20:26 -0400, Benjamin Marzinski wrote:
> > > The are multiple places in the code that can set pp->state to
> > > PATH_DOWN without resetting pp->checkint, most obviously when
> > > a path is failed by update_multipath(). When this happens the
> > > path will continue to be checked at its previous interval,
> > > instead of switching back to conf->checkint. Fix these cases
> > > by always resetting the pp->checkint to conf->checkint when
> > > updating the state of a failed path.
> > >
> > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> > Reviewed-by: Martin Wilck <mwilck@suse.com>
>
> Although this patch has no fixes: tag, I'll consider it for the stable
> branches. Objections?
Yeah. It makes sense for the stable branches.
-Ben
>
> Martin
prev parent reply other threads:[~2025-05-28 2:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 0:26 [PATCH] multipathd: always reset checker interval for failed paths Benjamin Marzinski
2025-05-23 11:00 ` Martin Wilck
2025-05-23 11:04 ` Martin Wilck
2025-05-28 2:01 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDZuageAzJxJHCeC@redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.