All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	James Clark <james.clark@linaro.org>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Howard Chu <howardchu95@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	Michael Petlan <mpetlan@redhat.com>,
	Anne Macedo <retpolanne@posteo.net>,
	"Dr. David Alan Gilbert" <linux@treblig.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf machine: Factor creating a "live" machine out of dwarf-unwind
Date: Wed, 28 May 2025 10:12:28 -0300	[thread overview]
Message-ID: <aDcLvCHGtGRHoA08@x1> (raw)
In-Reply-To: <CAP-5=fWaTU7Ouj6ZnF2jaoiQbT_Niavx-JA=_bMdYRsr7T-P8w@mail.gmail.com>

On Tue, May 27, 2025 at 02:17:40PM -0700, Ian Rogers wrote:
> On Tue, Mar 18, 2025 at 4:47 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > On Fri, Mar 14, 2025 at 05:01:51PM -0300, Arnaldo Carvalho de Melo wrote:
> > > On Fri, Mar 14, 2025 at 05:00:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > On Fri, Mar 14, 2025 at 02:18:49PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > On Wed, Mar 12, 2025 at 10:29:51PM -0700, Ian Rogers wrote:
> > > > > > Factor out for use in places other than the dwarf unwinding tests for
> > > > > > libunwind.

> > > > > Testing with another patchset being reviewed/tested, seems to work, if
> > > > > it showed the line number would be even better!

> > > > But it gets the lines, at least in this secoond attempt, after applying
> > > > Namhyungs fix for the previous problem (int16_t):

> > > Nevermind, this time I built with DEBUG=1, so DWARF, probably.

> > Can I get your Tested-by?
 
> Ping. Thanks,

⬢ [acme@toolbx perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test
⬢ [acme@toolbx perf-tools-next]$ git log --oneline -1 ; time make -C tools/perf build-test
9360bbbbbe349ad5 (HEAD -> perf-tools-next) perf test trace_summary: Skip --bpf-summary tests if no libbpf
make: Entering directory '/home/acme/git/perf-tools-next/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
                 make_static: cd . && make LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_PERF_READ_VDSOX32=1 NO_JVMTI=1 NO_LIBTRACEEVENT=1 NO_LIBELF=1 -j32  DESTDIR=/tmp/tmp.pLPZo5eOU4
              make_with_gtk2: cd . && make GTK2=1 -j32  DESTDIR=/tmp/tmp.UCW5KoJO7G
- /home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP: cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP  feature-dump
cd . && make FEATURE_DUMP_COPY=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP feature-dump
       make_install_prefix_O: cd . && make install prefix=/tmp/krava FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.ltUruVMFZe DESTDIR=/tmp/tmp.SF7aKXi9C9
  failed to find: /tmp/krava/etc/bash_completion.d/perf
           make_no_scripts_O: cd . && make NO_LIBPYTHON=1 NO_LIBPERL=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.dDLcnrMf0E DESTDIR=/tmp/tmp.EPrIBPWlr1
                  make_doc_O: cd . && make doc FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.BzKY8ivHAr DESTDIR=/tmp/tmp.VzvzdPnp0f
       make_no_syscall_tbl_O: cd . && make FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.5kxtJHPWTs DESTDIR=/tmp/tmp.jE9lxo6oW9
<SNIP>
              make_minimal_O: cd . && make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 NO_LIBZSTD=1 NO_LIBCAP=1 NO_CAPSTONE=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.lElrNycGd2 DESTDIR=/tmp/tmp.d7wt9o5uE5
cd . && make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1 NO_LIBZSTD=1 NO_LIBCAP=1 NO_CAPSTONE=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.lElrNycGd2 DESTDIR=/tmp/tmp.d7wt9o5uE5
  BUILD:   Doing 'make -j32' parallel build
Warning: Kernel ABI header differences:
  diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
Makefile.config:685: Warning: Disabled BPF skeletons as libelf is required by bpftool
Makefile.config:726: Disabling post unwind, no support found.
Makefile.config:863: Python support disabled by user
Makefile.config:968: No libllvm 13+ found, slower source file resolution, please install llvm-devel/llvm-dev

  GEN     /tmp/tmp.lElrNycGd2/common-cmds.h
  CC      /tmp/tmp.lElrNycGd2/dlfilters/dlfilter-test-api-v0.o
  CC      /tmp/tmp.lElrNycGd2/dlfilters/dlfilter-test-api-v2.o
<SNIP>
  CC      /tmp/tmp.lElrNycGd2/tests/dlfilter-test.o
  CC      /tmp/tmp.lElrNycGd2/util/tool.o
  CC      /tmp/tmp.lElrNycGd2/tests/sigtrap.o
  CC      /tmp/tmp.lElrNycGd2/tests/event_groups.o
  CC      /tmp/tmp.lElrNycGd2/util/sample.o
  CC      /tmp/tmp.lElrNycGd2/tests/symbols.o
  CC      /tmp/tmp.lElrNycGd2/util/sample-raw.o
  CC      /tmp/tmp.lElrNycGd2/util/s390-sample-raw.o
  CC      /tmp/tmp.lElrNycGd2/tests/util.o
util/debug.c: In function ‘__dump_stack’:
util/debug.c:323:17: error: implicit declaration of function ‘backtrace_symbols_fd’ [-Wimplicit-function-declaration]
  323 |                 backtrace_symbols_fd(stackdump, stackdump_size, fileno(file));
      |                 ^~~~~~~~~~~~~~~~~~~~
  CC      /tmp/tmp.lElrNycGd2/util/amd-sample-raw.o
make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:85: /tmp/tmp.lElrNycGd2/util/debug.o] Error 1
make[6]: *** Waiting for unfinished jobs....
  CC      /tmp/tmp.lElrNycGd2/tests/hwmon_pmu.o
  CC      /tmp/tmp.lElrNycGd2/tests/tool_pmu.o
  MKDIR   /tmp/tmp.lElrNycGd2/tests/workloads/
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/noploop.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/thloop.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/leafloop.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/sqrtloop.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/brstack.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/datasym.o
  CC      /tmp/tmp.lElrNycGd2/tests/workloads/landlock.o
  LD      /tmp/tmp.lElrNycGd2/tests/workloads/perf-test-in.o
  LD      /tmp/tmp.lElrNycGd2/tests/perf-test-in.o
  LD      /tmp/tmp.lElrNycGd2/perf-test-in.o
  AR      /tmp/tmp.lElrNycGd2/libperf-test.a
  LD      /tmp/tmp.lElrNycGd2/perf-in.o
make[5]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:142: util] Error 2
make[4]: *** [Makefile.perf:798: /tmp/tmp.lElrNycGd2/perf-util-in.o] Error 2
make[4]: *** Waiting for unfinished jobs....
  CC      /tmp/tmp.lElrNycGd2/pmu-events/pmu-events.o
  LD      /tmp/tmp.lElrNycGd2/pmu-events/pmu-events-in.o
make[3]: *** [Makefile.perf:290: sub-make] Error 2
make[2]: *** [Makefile:76: all] Error 2
make[1]: *** [tests/make:341: make_minimal_O] Error 1
make: *** [Makefile:109: build-test] Error 2
make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'

real	3m7.724s
user	31m43.201s
sys	5m40.288s
⬢ [acme@toolbx perf-tools-next]$

      reply	other threads:[~2025-05-28 13:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  5:29 [PATCH v1 1/2] perf machine: Factor creating a "live" machine out of dwarf-unwind Ian Rogers
2025-03-13  5:29 ` [PATCH v1 2/2] perf debug: Add function symbols to dump_stack Ian Rogers
2025-03-14 17:18 ` [PATCH v1 1/2] perf machine: Factor creating a "live" machine out of dwarf-unwind Arnaldo Carvalho de Melo
2025-03-14 20:00   ` Arnaldo Carvalho de Melo
2025-03-14 20:01     ` Arnaldo Carvalho de Melo
2025-03-18 23:47       ` Namhyung Kim
2025-05-27 21:17         ` Ian Rogers
2025-05-28 13:12           ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDcLvCHGtGRHoA08@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dvyukov@google.com \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=retpolanne@posteo.net \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.