Re: [PATCH v8 3/3] rust: platform: allow ioremap of platform resources

[Danilo Krummrich <dakr@kernel.org>]

On Wed, May 28, 2025 at 02:29:44PM -0300, Daniel Almeida wrote:
> Hi Danilo,
> 
> […]
> 
> > 
> >> +    ///     let offset = 0; // Some offset.
> >> +    ///
> >> +    ///     // If the size is known at compile time, use `ioremap_resource_sized`.
> >> +    ///     // No runtime checks will apply when reading and writing.
> >> +    ///     let resource = pdev.resource(0).ok_or(ENODEV)?;
> >> +    ///     let iomem = pdev.ioremap_resource_sized::<42>(&resource)?;
> >> +    ///
> >> +    ///     // Read and write a 32-bit value at `offset`. Calling `try_access()` on
> >> +    ///     // the `Devres` makes sure that the resource is still valid.
> >> +    ///     let data = iomem.try_access().ok_or(ENODEV)?.read32_relaxed(offset);
> >> +    ///
> >> +    ///     iomem.try_access().ok_or(ENODEV)?.write32_relaxed(data, offset);
> > 
> > Since this won't land for v6.16, can you please use Devres::access() [1]
> > instead? I.e.
> > 
> > let iomem = pdev.ioremap_resource_sized::<42>(&resource)?;
> > let io = Devres::access(pdev.as_ref())?;
> > 
> > let data = io.read32_relaxed(offset);
> > io.write32_relaxed(data, offset);
> > 
> > Devres::access() is in nova-next and lands in v6.16.
> > 
> > [1] https://gitlab.freedesktop.org/drm/nova/-/commit/f301cb978c068faa8fcd630be2cb317a2d0ec063
> 
> Devres:access takes &Device<Bound>, but the argument in probe() is
> &Device<Core>.
> 
> Are these two types supposed to convert between them? I see no explicit
> function to do so.

Yes, it comes from impl_device_context_deref!() [1], which, as the name implies,
implements the corresponding Deref traits.

Device dereference in the following way:

	&Device<Core> -> &Device<Bound> -> &Device (i.e. &Device<Normal>)

You can just pass in the &Device<Core>, it will work.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git/tree/rust/kernel/device.rs?h=driver-core-next#n284