From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E4922069E for ; Wed, 28 May 2025 19:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748461139; cv=none; b=TMAjs072kw+A2WIJNKfRzGefSfKJATgMQPlBwViYedHK1S7RxVeftzJLw+puwbxiwCcrbN4XcTqiH3/brOBfAE5RUJ5qhkcr5dKZ7Ou02u/xh4vgIFHzaTeqW+B4CdXlKtmjLwv3T1B11y+Yp2Wim78uTpjpTCxlmcI9OQ3fmTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748461139; c=relaxed/simple; bh=qAlgiZE6ubh5iHvoct1giz6jhFlPlq4WJUF0qIjr0bc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=euFA1IG8+wL+h9xJ4qCRtCaYmYP9iR+5dM3/GXQ806fQKE+/WSuFRV7G9eI9jiQXmAQAbUAR2cLy59sz42FPtUEiGT00MFVEwQ9FQxLkoRb7apHDWsK810cDF19aWQVEKF7/SKyiFwNWkANfq3hQjF8vyHIW/eUHHtNwC/OkmXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JGqNr3o3; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JGqNr3o3" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a36e950e41so136048f8f.0 for ; Wed, 28 May 2025 12:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748461136; x=1749065936; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=plXt1Ax7l5ZZocx/9iEw4j8ASiL+K7iAWJMDAiTUmzM=; b=JGqNr3o3MciDVlLczWfQw4vdehz4oTxVTu1idec4utdfYv+QzyVKpX8ZCtTwuajQH+ 2Y1PILGWHd3LIwYfAgH6AuiQj5ZLWjpoa9/KhCUIros5YNuqyS4SqHdal7o4aws46elU 6FIY4nR03XTKg2KNqZVuzTZetuTtUwFI1U0pYp246xkNHYE2/0IQGZTXdKkF74ynxeoZ 5Amd67SA0bh3OtC/qowo5/T1VRLPUnyucehgx/FrxgSFozgIfGstVEQoK4T4xypuhlxI d6BbFXJk+36eRKq9h/xlwicsGf3L3+/BN+HpmnY+t5keBXexWHqSqJUwWNPa4mRUkkE7 eUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748461136; x=1749065936; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=plXt1Ax7l5ZZocx/9iEw4j8ASiL+K7iAWJMDAiTUmzM=; b=P7pXchu6vnxGpOWGyS7Y4+9+3hO4Ud8cbLctdZnhVH2e1qSIeL5UY2cn0lwA8oBUjY qgRK+DPssv2Xaca1JZGHKAepFuzdtnBU+E/l079xCt2ts66xmLdNALqZHH/6zSrWuSH7 VGC5Huo/NCbkd2Xci5pfS3qaCvwrLxTZIoX/u+ldSyNLNVdCqmEUmpMz3x1f9igwkbej LKYuu02EknAzyk9RDRO4P7vXn0PmBYO9PuadGV0qcFA8uTcCj6Xi5M5OgvxAHGsFKd7e 3+a2YqTcOCySzKqBObRUEMCfAEQUn1jSSAOsfg9to6E9YNhCFKPyVf4ozMpEH5/V+6OI QpYg== X-Forwarded-Encrypted: i=1; AJvYcCUKecamlqVUnUy1a72X49P+Qo0uN1euAi3L2/BNbu0TNc2UJa9kQk0dC84H8gNUPenegRL3Mo+L2FsgPw==@vger.kernel.org X-Gm-Message-State: AOJu0YxVpKCQ+JiZ1qqQafQMxUSa1XZNIxyJ7nIiLQiYoXVtK6jYOatU 8DmwR2fuFvFziRkfv9nRKNp0kBcCBFcdUxI+X9g539JCbS3tePw9hahRYXYUtW+72Zc= X-Gm-Gg: ASbGncup4Brtb3He14VxTjl8bGlvcvihZTQK+SuXqjwkdSv+Qb+xStP5VwUcQ0ZUkrS sbsXg1huNRgZbqYgABprmAtxJLdwiNJGJyk7GjTye6ptSg0IJfK52w05PRob2NeIrK4nt6Y4GNN dofQzRn/xdu/NTtfuMlMYaBTB15jAQfjq36/Eofmg2infLJtGV81/EyFMm2tKNUYf0FlOzsNcWA Q/uoGGHTyPB1YDD1gS+FOsOoTXEu0kf+tjYOyvQy7Vj2ZlUgi6GgiGp4AZ0FlSKMB8bXMAlgKda Yi0KTJIvWI01Srqe7thjv5gxA67C0OblmMYFwZpHtQsyi9UvCQBZTt8= X-Google-Smtp-Source: AGHT+IEohOPMzN+pE/FspwUOZyTq3f/DaGNNjqVAcD+QKVM4fgErWjBcDpyCCi/2vxtZ5wPSlADAxA== X-Received: by 2002:a05:6000:2504:b0:3a4:e387:c0bb with SMTP id ffacd0b85a97d-3a4e387c5afmr8004139f8f.59.1748461136127; Wed, 28 May 2025 12:38:56 -0700 (PDT) Received: from localhost ([41.210.143.146]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a4eacd6e8asm2265146f8f.70.2025.05.28.12.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 12:38:55 -0700 (PDT) Date: Wed, 28 May 2025 22:38:51 +0300 From: Dan Carpenter To: Bram Vlerick Cc: Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: add invert display parameter Message-ID: References: <20250528-ili9341-invert-dtb-v1-1-080202809332@openpixelsystems.org> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250528-ili9341-invert-dtb-v1-1-080202809332@openpixelsystems.org> On Wed, May 28, 2025 at 05:42:30PM +0200, Bram Vlerick wrote: > Add devicetree parameter to enable or disable the invert feature of the > ili9341 display > This commit message is so unclear. The parameter doesn't let you --and this is a direct quote. LOL-- "disable the invert feature". It would be better to say "Add devicetree parameter to invert the display on a ili9341 device." regards, dan carpenter