From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, danieller@nvidia.com, netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 2/2] module_common: print loss / fault signals as bool
Date: Thu, 29 May 2025 18:53:27 +0300 [thread overview]
Message-ID: <aDiC9_sW5VArKBBi@shredder> (raw)
In-Reply-To: <20250529142033.2308815-3-kuba@kernel.org>
On Thu, May 29, 2025 at 07:20:33AM -0700, Jakub Kicinski wrote:
> JSON output is supposed to be easy to parse. We currently
> output "Yes" / "No" for the per-lane signal loss / fault.
> This forces user space to do string matching. Print bool.
>
> Before:
> "rx_loss_of_signal": ["No", "No", "No", "No"],
>
> After:
> "rx_loss_of_signal": [false, false, false, false],
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-05-29 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 14:20 [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Jakub Kicinski
2025-05-29 14:20 ` [PATCH ethtool 1/2] module_common: always print per-lane status in JSON Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel
2025-05-29 14:20 ` [PATCH ethtool 2/2] module_common: print loss / fault signals as bool Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel [this message]
2025-05-29 23:02 ` [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Joe Damato
2025-05-30 11:35 ` Michal Kubecek
2025-05-31 1:20 ` Jakub Kicinski
2025-06-10 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDiC9_sW5VArKBBi@shredder \
--to=idosch@idosch.org \
--cc=danieller@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.