From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD13AC5B543 for ; Fri, 30 May 2025 11:29:30 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 24BD03C9375 for ; Fri, 30 May 2025 13:29:29 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CD91C3C76FD for ; Fri, 30 May 2025 13:29:11 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id CED421A004CC for ; Fri, 30 May 2025 13:29:05 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3C0631FB3B; Fri, 30 May 2025 11:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748604543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uFKH0I48OvlH+r+u1FLqDxHlqtQQ8/ruAy9U89yXBU=; b=Vk9CqZilmhJSKH+GEqiDw9+BPBbW99I5C50KFTIDInvhzYOYGoHgU6wWC9ZoyKpRS8RovQ 0Y1f2ldh6CD+n+gIEDkLojrmOJiU1TM6XezOPKcklBqWkslnSpGZ9bezx3gSHdKSF5Ypge K6w7+oYaavXbl3Nym5CecfmTamXsevM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748604543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uFKH0I48OvlH+r+u1FLqDxHlqtQQ8/ruAy9U89yXBU=; b=ZToKTmP4TQbeFeppRto0AaPlgA33Gn2wcML8rjp6sxUL+49TYOW030LdMp2HrxF0zmHryf tD4zAh4NbKVzvWAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748604543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uFKH0I48OvlH+r+u1FLqDxHlqtQQ8/ruAy9U89yXBU=; b=Vk9CqZilmhJSKH+GEqiDw9+BPBbW99I5C50KFTIDInvhzYOYGoHgU6wWC9ZoyKpRS8RovQ 0Y1f2ldh6CD+n+gIEDkLojrmOJiU1TM6XezOPKcklBqWkslnSpGZ9bezx3gSHdKSF5Ypge K6w7+oYaavXbl3Nym5CecfmTamXsevM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748604543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uFKH0I48OvlH+r+u1FLqDxHlqtQQ8/ruAy9U89yXBU=; b=ZToKTmP4TQbeFeppRto0AaPlgA33Gn2wcML8rjp6sxUL+49TYOW030LdMp2HrxF0zmHryf tD4zAh4NbKVzvWAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2CEE5132D8; Fri, 30 May 2025 11:29:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ob//CX+WOWh0FQAAD6G6ig (envelope-from ); Fri, 30 May 2025 11:29:03 +0000 Date: Fri, 30 May 2025 13:29:24 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20250530-fix_irqbalance-v1-1-6509384f52db@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250530-fix_irqbalance-v1-1-6509384f52db@suse.com> X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,imap1.dmz-prg2.suse.org:helo] X-Virus-Scanned: clamav-milter 1.0.7 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] irq: informative TINFO for irqbalance01 result X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > + tst_res(TFAIL, > + "IRQ balancing has not been detected. It might be that:\n" > + "- balancing service is not running\n" > + "- balancing service is running but rules didn't change\n" > + "- balancing rules have been changed, but CPUs didn't perform any interrupt"); This looks like an abuse of the tst_res() interface. I would have kept the TFAIL message as it was and added the hints with tst_printf(), which is used in the test to print debug information anyways. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp