From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A12C6C5B543 for ; Fri, 30 May 2025 13:28:07 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id D475B3C932C for ; Fri, 30 May 2025 15:28:05 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 301713C9298 for ; Fri, 30 May 2025 15:27:48 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 5E13E1400777 for ; Fri, 30 May 2025 15:27:47 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BFB7C21CA6; Fri, 30 May 2025 13:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748611666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5nC+0fv0sKDl/zG7NRZlB7bYMJ3GFFePe2278bGh3k=; b=gcBXaMuYZEDAcKMdwh+XfX5q2T0ZrcDB1QeG45r9fCrisma9MchhYOurDZTXhCw8BRkjjM m2fX7RqLU37Nk+3OI39ZpxivVm8ftuNsZJinA2EAl6amCOWygrGMZngIjT/cOHvO6TvNXX 9GotuOlj/55O6V1lU45YvienK1rPT0M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748611666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5nC+0fv0sKDl/zG7NRZlB7bYMJ3GFFePe2278bGh3k=; b=TCYAa+h8ye9xIIHtqpQx5DhscI9wnNoDCkbTNzEn0pmz5Yrmg6oVhoUbflyfhHKMMJdmqy ff0qwYT6Ii6fn0Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748611666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5nC+0fv0sKDl/zG7NRZlB7bYMJ3GFFePe2278bGh3k=; b=gcBXaMuYZEDAcKMdwh+XfX5q2T0ZrcDB1QeG45r9fCrisma9MchhYOurDZTXhCw8BRkjjM m2fX7RqLU37Nk+3OI39ZpxivVm8ftuNsZJinA2EAl6amCOWygrGMZngIjT/cOHvO6TvNXX 9GotuOlj/55O6V1lU45YvienK1rPT0M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748611666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G5nC+0fv0sKDl/zG7NRZlB7bYMJ3GFFePe2278bGh3k=; b=TCYAa+h8ye9xIIHtqpQx5DhscI9wnNoDCkbTNzEn0pmz5Yrmg6oVhoUbflyfhHKMMJdmqy ff0qwYT6Ii6fn0Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AE18413889; Fri, 30 May 2025 13:27:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rHEKKVKyOWhxNwAAD6G6ig (envelope-from ); Fri, 30 May 2025 13:27:46 +0000 Date: Fri, 30 May 2025 15:28:08 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20250530-fix_irqbalance-v1-1-6509384f52db@suse.com> <42cacf3d-148a-46f9-9044-3c573779a8b9@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <42cacf3d-148a-46f9-9044-3c573779a8b9@suse.com> X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.7 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] irq: informative TINFO for irqbalance01 result X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > This looks like an abuse of the tst_res() interface. I would have kept > > the TFAIL message as it was and added the hints with tst_printf(), which > > is used in the test to print debug information anyways. > > The debug information is useful, but the error message is really vague, > even if correct. > The meaning of the patch is to add information so the user knows what's > going on, even if he/she doesn't know the test really well. That's why I suggested to print the hints with tst_printf() instead of tst_res(). -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp